Skip to content

AOT: fix ZipArchive setArchiveComment/getArchiveComment under thin AOT (#35476) - #35736

Merged
PurHur merged 1 commit into
masterfrom
agent/issue-35476-ziparchive-comment-aot
Aug 29, 2026
Merged

AOT: fix ZipArchive setArchiveComment/getArchiveComment under thin AOT (#35476)#35736
PurHur merged 1 commit into
masterfrom
agent/issue-35476-ziparchive-comment-aot

Conversation

@PurHur

@PurHur PurHur commented Aug 29, 2026

Copy link
Copy Markdown
Owner

Summary

Verification

./script/aot-smoke.sh
# aot-smoke: 8 passed, 0 failed

./script/phpunit.sh --filter ZipArchiveArchiveComment35476AotTest
# OK (2 tests, 9 assertions)

./script/docker-exec.sh -- bash -lc 'PHP_COMPILER_ENABLE_ZIP=1 php bin/vm.php test/repro/ziparchive_archive_comment_aot.php'
# empty=false / set=true / get='c' / reopen='c'

./script/docker-exec.sh -- bash -lc 'PHP_COMPILER_ENABLE_ZIP=1 php bin/compile.php -o /tmp/z test/repro/ziparchive_archive_comment_aot.php && /tmp/z'
# same output as VM

Closes #35476

Made with Cursor

…pers (#35476).

exec() formal aliasing dropped setArchiveComment payloads under thin AOT;
peer addEntry/replaceEntry split (#35454/#35710).

Co-authored-by: Cursor <cursoragent@cursor.com>
@PurHur
PurHur merged commit cbc9877 into master Aug 29, 2026
1 check passed
@PurHur
PurHur deleted the agent/issue-35476-ziparchive-comment-aot branch August 29, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AOT: ZipArchive::setArchiveComment/getArchiveComment return null — ExternalMethod stubs (leftover of #35450, ext/zip/php_zip.c)

1 participant