Fix Python.NET GIL shutdown finalizer crash - #9811
Open
jassim1977 wants to merge 1 commit into
Open
jassim1977 wants to merge 1 commit into
jassim1977 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes an undisposed
Py.GIL()acquisition immediately beforePythonEngine.Shutdown().With Python.Runtime 2.0.66 and Python 3.11.16 on Windows, the retained GIL state reaches finalization after engine shutdown and raises:
System.InvalidOperationException: GIL must always be released, and it must be released from the same thread that acquired it.Reproduction before fix
PythonInitializer.Shutdown().Py.GILState.Finalize().-532462766.Validation after fix
PythonInitializer.Shutdown(): ended.GIL must always be releasedfailure occurred.This change is intentionally limited to one line in
PythonInitializer.Shutdown().