Delete the three migrated wave-C1 copies (Track C) - #373
Merged
Conversation
The lectures have read these from QuantEcon/data-lectures since #372, and publish-2026aug17 has since shipped that repoint, so the local copies are no longer reachable by anything. The publish gate was verified rather than assumed, and by basename rather than by URL. Before the publish, both published notebooks carried zero `data-lectures` references and one `_static/lecture_specific` each; after it, both carry `data-lectures` and zero `_static/lecture_specific`, and the generated lecture-python-advanced.notebooks mirror matches. That ordering is what makes this deletion safe, and it mattered most for hansen_jagannathan_1991_data.json, which is fetched over the network at cell-execution time: deleting it while a published notebook still named the old URL would have broken every notebook and Colab reader instantly, with no cache rebuild to ride out. An org-wide sweep re-derived the consumer set at deletion time rather than trusting the one taken when the wave was planned. All 278 QuantEcon repos enumerated, 277 with a default branch swept over the Trees API, authenticated so the 69 private repos are covered rather than silently 404ing. The three filenames appear in exactly two repos: data-lectures, which is their new home, and this one. Positive control fired (this repo's own copies were found); negative control returned zero. Both `_static/lecture_specific/` directories held nothing but the migrated files, so git removes them entirely. The published site keeps serving these paths until the next cache rebuild and publish — every repo here restores a cached `_build/html` and Sphinx never prunes assets removed from source. That is expected under the settle policy agreed for this migration, not a failure of this PR: the deletion is complete on `main`, and the site clears on the weekly cycle. Verify a deletion against the published URL, never against `main`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for lustrous-melomakarona-3ee73e ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes three now-unreferenced Wave C1 dataset copies from this repo’s lectures/_static/lecture_specific/... tree after the corresponding lectures were repointed to load the same datasets from QuantEcon/data-lectures (per #372), reducing repo size and eliminating duplicated assets.
Changes:
- Delete
bbh_michigan_monthly.csvlocal copy forsubjective_beliefs_business_cycles. - Delete
bbh_macro_quarterly.csvlocal copy forsubjective_beliefs_business_cycles. - Delete
hansen_jagannathan_1991_data.jsonlocal copy forhansen_jagannathan_1991.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lectures/_static/lecture_specific/subjective_beliefs_business_cycles/bbh_michigan_monthly.csv | Removes migrated local dataset copy (now loaded from data-lectures). |
| lectures/_static/lecture_specific/subjective_beliefs_business_cycles/bbh_macro_quarterly.csv | Removes migrated local dataset copy (now loaded from data-lectures). |
| lectures/_static/lecture_specific/hansen_jagannathan_1991/hansen_jagannathan_1991_data.json | Removes migrated local dataset copy (now loaded from data-lectures). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The final step of wave C1. The lectures have read these from QuantEcon/data-lectures since #372, and
publish-2026aug17has shipped that repoint, so nothing reaches the local copies any more.The publish gate, measured
Verified by basename, not by URL — a grep for the assembled URL returns a confident zero against a split literal, which is exactly how this check gives a false pass:
data-lecturesrefs_static/lecture_specificrefs.notebooksmirror, afterThat ordering is what makes the deletion safe, and it mattered most for
hansen_jagannathan_1991_data.json: it is fetched over the network at cell-execution time, so deleting it while a published notebook still named the old URL would have broken every notebook and Colab reader instantly, with no cache rebuild to ride out.Consumer sweep, re-derived at deletion time
Not carried over from when the wave was planned — that is the rule QuantEcon/workspace-lectures#28 exists to enforce.
All 278 QuantEcon repos enumerated; 277 with a default branch swept over the Trees API, authenticated, so the 69 private repos are covered rather than silently 404ing. The three filenames appear in exactly two repos:
data-lectures— their new home, plus the three sidecar manifestsPositive control fired (this repo's own copies were found); negative control returned zero.
Both
_static/lecture_specific/directories held nothing but the migrated files, so git removes the directories too.What this does not do
The published site keeps serving these paths until the next cache rebuild and publish — every repo in the family restores a cached
_build/html, and Sphinx never prunes assets removed from source. That is expected under the settle policy agreed for this migration rather than a gap in this PR: the deletion is complete onmain, and the site clears on the weekly cycle. Verify a deletion against the published URL, never againstmain.Baseline for whoever checks later: all three currently return 200 from
python-advanced.quantecon.orgat 32,217 / 12,196 / 63,456 bytes, against a 404 control. The raw blobs onmain404 as soon as this merges.🤖 Generated with Claude Code