Fix custom accessibility actions vanishing after rebind - #1376
Open
codeofdusk wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
CC @QuantumBadger. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom accessibility actions whose label matches the configured click/long-click hint (such as collapse with the default click action) intermittently disappear from the accessibility actions list. Androidx's
ViewCompat.addAccessibilityActionreuses the id of any existing action that has a matching label, and the click/long-click hints (#1047) are labelled standard actions thatremoveAllActionsnever cleared. So on every other rebind the custom action gets attached toACTION_CLICK's id and is then destroyed when the hint is re-set. This PR clears the hints inremoveAllActionsbefore deleting tracked actions; callers reset them when re-registering. Tested on a Pixel 6A (Bluejay); actions and hints consistently appear as expected.