Change demo page to navigate to project URLs - #1585
Merged
Merged
Conversation
zetter-rpf
temporarily deployed
to
previews/1585/merge
August 10, 2026 16:09 — with
GitHub Actions
Inactive
zetter-rpf
force-pushed
the
fix-flakey-resize-test
branch
from
August 10, 2026 16:13
4cc459e to
6eb8a65
Compare
zetter-rpf
temporarily deployed
to
previews/1585/merge
August 10, 2026 16:14 — with
GitHub Actions
Inactive
zetter-rpf
force-pushed
the
fix-flakey-resize-test
branch
from
August 11, 2026 08:08
6eb8a65 to
7c754c8
Compare
We're now using these more in our E2E tests. Clicking on the navigation link in the tests is a problem as it means the editor is initialized twice. This can slow down the tests and make the tests flakey if they are asserting an element that is removed from the page. Doing this also enables you to refresh the page in development without loosing the project which is nice.
zetter-rpf
force-pushed
the
fix-flakey-resize-test
branch
from
August 11, 2026 08:08
7c754c8 to
2b33afa
Compare
zetter-rpf
temporarily deployed
to
previews/1585/merge
August 11, 2026 08:08 — with
GitHub Actions
Inactive
zetter-rpf
marked this pull request as ready for review
August 11, 2026 08:12
Contributor
HUGE |
cocomarine
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're now using this demo page more in our E2E tests. Clicking on the navigation link in the tests is a problem as it means the editor is initialized twice. This can slow down the tests and make the tests flakey if they are asserting an element that is removed from the page.
Doing this also enables you to refresh the page in development without loosing the project which is nice.
Thanks to @cocomarine and @DNR500 for discovering this might be causing some intermittent failures for the resize tests. This was fixed as part of #1561, this is a more general change to prevent similar issues for other tests in the future.