Skip to content

Change demo page to navigate to project URLs - #1585

Merged
zetter-rpf merged 2 commits into
mainfrom
fix-flakey-resize-test
Aug 11, 2026
Merged

Change demo page to navigate to project URLs#1585
zetter-rpf merged 2 commits into
mainfrom
fix-flakey-resize-test

Conversation

@zetter-rpf

@zetter-rpf zetter-rpf commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

We're now using this demo page more in our E2E tests. Clicking on the navigation link in the tests is a problem as it means the editor is initialized twice. This can slow down the tests and make the tests flakey if they are asserting an element that is removed from the page.

Doing this also enables you to refresh the page in development without loosing the project which is nice.

Thanks to @cocomarine and @DNR500 for discovering this might be causing some intermittent failures for the resize tests. This was fixed as part of #1561, this is a more general change to prevent similar issues for other tests in the future.

@zetter-rpf
zetter-rpf temporarily deployed to previews/1585/merge August 10, 2026 16:09 — with GitHub Actions Inactive
@zetter-rpf
zetter-rpf force-pushed the fix-flakey-resize-test branch from 4cc459e to 6eb8a65 Compare August 10, 2026 16:13
@zetter-rpf
zetter-rpf temporarily deployed to previews/1585/merge August 10, 2026 16:14 — with GitHub Actions Inactive
@zetter-rpf
zetter-rpf force-pushed the fix-flakey-resize-test branch from 6eb8a65 to 7c754c8 Compare August 11, 2026 08:08
We're now using these more in our E2E tests. Clicking on the navigation link in the tests is a problem as it means the editor is initialized twice. This can slow down the tests and make the tests flakey if they are asserting an element that is removed from the page.

Doing this also enables you to refresh the page in development without loosing the project which is nice.
@zetter-rpf
zetter-rpf force-pushed the fix-flakey-resize-test branch from 7c754c8 to 2b33afa Compare August 11, 2026 08:08
@zetter-rpf
zetter-rpf temporarily deployed to previews/1585/merge August 11, 2026 08:08 — with GitHub Actions Inactive
@zetter-rpf
zetter-rpf marked this pull request as ready for review August 11, 2026 08:12
@maxelkins

Copy link
Copy Markdown
Contributor

Doing this also enables you to refresh the page in development without loosing the project which is nice.

HUGE

@zetter-rpf
zetter-rpf merged commit 445f6c2 into main Aug 11, 2026
8 checks passed
@zetter-rpf
zetter-rpf deleted the fix-flakey-resize-test branch August 11, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants