Skip the TS-GCN installer in the CI install lane - #1040
Closed
calvinp0 wants to merge 1 commit into
Closed
Conversation
`make install-ci` builds the `ts_gcn` environment on every run, and that environment's PyTorch Geometric wheels (torch-scatter, torch-sparse, torch-cluster, torch-spline-conv) are all served from data.pyg.org. That host stopped resolving on 2026-09-02 (pyg-team/pyg-lib#719), and because install_all.sh runs under `set -euo pipefail`, the failed pip step aborts the whole install before a single test runs. Main's scheduled run and every open PR have been red since. Nothing in CI executes the ts_gcn environment: gcn_test.py patches the interpreter path and mocks the subprocess boundary, settings resolve TS_GCN_PYTHON to None when the env is absent, and gcn_available() already handles that. The install was pure cost. install_all.sh gains --no-gcn, the same shape as --no-goflow and --no-rits, and install-ci passes it. With the installer gone nothing clones ../TS-GCN on the runner, so the PYTHONPATH step now adds only AutoTST instead of printing a realpath error for a directory that no longer exists. `make install-gcn` and a plain `make install` still build the environment for real deployments.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1040 +/- ##
==========================================
- Coverage 65.56% 65.56% -0.01%
==========================================
Files 120 120
Lines 40516 40516
Branches 10441 10441
==========================================
- Hits 26565 26563 -2
- Misses 10948 10952 +4
+ Partials 3003 3001 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
data.pyg.org is back |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why CI is red
Every CI run since 2026-09-02 fails in
make install-cibefore a single test executes, onmainand on every open PR. The GCN installer builds thets_gcnenvironment fromdevtools/gcn_environment.yml, whose PyTorch Geometric wheels (torch-scatter,torch-sparse,torch-cluster,torch-spline-conv) are linked frompytorch-geometric.com/whl/torch-1.7.1+cpu.htmltodata.pyg.org. That host stopped resolving on 2026-09-02 (dangling CNAME to a retired CloudFront distribution; tracked upstream at pyg-team/pyg-lib#719 with no ETA).install_all.shruns underset -euo pipefail, so the failed pip step aborts the whole install.What we realised along the way
TS-GCN is not tested anywhere in our CI flow.
gcn_test.pypatchesTS_GCN_PYTHONand mocks the subprocess boundary,settings.pyresolvesTS_GCN_PYTHONtoNonewhen the environment is absent, andgcn_available()already handles that. No workflow step runs thets_gcninterpreter. CI has been building a heavyweight environment on every run and never using it.Change
devtools/install_all.shgains--no-gcn, the same shape as--no-goflowand--no-rits.make install-cipasses it.make installandmake install-gcnstill build the environment for real deployments.../TS-GCNon the runner any more, so the old line would print arealpatherror on every run.Verified that no other installer still in the CI lane fetches from the dead host (
install_goflow.shandinstall_rits.shreference it but were already outsideinstall-ci), thatdocker_build.ymlnever callsinstall_all.sh, and that the associative-arrayunsetbehaves underset -u.🤖 Generated with Claude Code
https://claude.ai/code/session_0155RJ4VFRKpXQPEUBU2G4ho