Skip to content

RG-T129 Delete Repo bug #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ucswift merged 1 commit into from
Aug 7, 2026
Merged

RG-T129 Delete Repo bug #449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Repositories/Resgrid.Repositories.DataRepository/DeleteRepository.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@ public async Task<bool> DeleteDepartmentAndUsersAsync(int departmentId)

if (Config.DataConfig.DatabaseType == DatabaseTypes.SqlServer)
{
using (IDbConnection db = new SqlConnection(DataConfig.CoreConnectionString))
using (var db = new SqlConnection(DataConfig.CoreConnectionString))
{
await db.OpenAsync();

@Resgrid-Bot Resgrid-Bot Aug 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kody code-review Kody Rules high

Unguarded db.OpenAsync() call risks throwing an unhandled exception upon a database connection failure. Wrap OpenAsync and the subsequent transaction/ExecuteAsync block in a try/catch that logs context and handles or rethrows the error appropriately to comply with Rule [1].

Kody rule violation: Handle async operations with proper error handling

Prompt for LLM 

File Repositories/Resgrid.Repositories.DataRepository/DeleteRepository.cs:

Line 29:

Unguarded `db.OpenAsync()` call risks throwing an unhandled exception upon a database connection failure. Wrap `OpenAsync` and the subsequent transaction/`ExecuteAsync` block in a try/catch that logs context and handles or rethrows the error appropriately to comply with Rule [1].

Talk to Kody by mentioning @kody

Was this suggestion helpful? React with 👍 or 👎 to help Kody learn from this interaction.

​

​

@Resgrid-Bot Resgrid-Bot Aug 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kody code-review Kody Rules high

Unguarded external database call in db.OpenAsync() omits mandated error mapping per Rule [27]. Wrap the OpenAsync call in a try/catch, log the relevant departmentId identifier, and map exceptions to an application-level error or rethrow with context.

Kody rule violation: Add try-catch blocks for external calls

Prompt for LLM 

File Repositories/Resgrid.Repositories.DataRepository/DeleteRepository.cs:

Line 29:

Unguarded external database call in `db.OpenAsync()` omits mandated error mapping per Rule [27]. Wrap the `OpenAsync` call in a try/catch, log the relevant `departmentId` identifier, and map exceptions to an application-level error or rethrow with context.

Talk to Kody by mentioning @kody

Was this suggestion helpful? React with 👍 or 👎 to help Kody learn from this interaction.

​

​


using (var transaction = db.BeginTransaction())
{
var result = await db.ExecuteAsync(@"
Expand Down Expand Up @@ -171,13 +173,13 @@ DELETE FROM [dbo].[MessageRecipients] WHERE MessageId IN (SELECT MessageId FROM
DELETE FROM [dbo].[AspNetUsersExt] WHERE UserId = @ManagingUserId
DELETE FROM [dbo].[AspNetUsers] WHERE Id = @ManagingUserId
",
new { DepartmentId = departmentId });
new { DepartmentId = departmentId }, transaction);

transaction.Commit();
}
}

return false;
return true;
}

return false;
Expand Down
Loading