Skip to content

Keep the Store app list scroll host active #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Richasy merged 1 commit into from
Sep 4, 2026
Merged

Keep the Store app list scroll host active #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/LoopbackManager.Shell/Controls/AppList.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ namespace LoopbackManager.Shell.Controls;
/// and overlays the phase views — a virtualized <c>ItemsRepeater</c> of <see cref="AppCard"/> rows when the load
/// succeeded with results, a centered spinner while loading, a retryable error, and an empty-state message — each shown
/// by <c>.Visible</c> off the store's reactive phase flags, so a load settling or a filter change re-renders the right
/// one. The phases are mutually exclusive, so exactly one overlay child is visible at a time; the <c>ItemsRepeater</c>
/// stays mounted across phases (collapsed, then reconciled in place) rather than torn down and rebuilt. Because
/// one. The <c>ScrollView</c> always participates in layout, including while its repeater is empty, so its native input
/// host is established once instead of joining the composition tree only when loading finishes. Because
/// <see cref="AppCard"/> is a <c>Control</c> (a live checkbox + open-folder button per row), it goes in through the
/// two-closure <c>ItemsRepeater</c> overload; only a screenful is realized.
/// </summary>
Expand All @@ -27,9 +27,6 @@ public sealed partial class AppList : Control

public AppList() => _store = Application.Current.Services.GetRequiredService<AppStore>();

// Success with at least one (filtered) row → show the list.
private bool ShowList => _store.Apps.IsSuccess && _store.FilteredApps.Count > 0;

// Success but no (filtered) rows → show the empty state (covers both "no apps" and "no search match").
private bool ShowEmpty => _store.Apps.IsSuccess && _store.FilteredApps.Count == 0;

Expand Down Expand Up @@ -57,8 +54,7 @@ public sealed partial class AppList : Control
)
.Vertical(ScrollMode.Auto)
.HorizontalScrollBar(ScrollBarVisibility.Hidden)
.Padding(12f, 0f)
.Visible(ShowList),
.Padding(12f, 0f),
Stack(
ProgressRing(new Size(32f, 32f)).HAlign(HorizontalAlignment.Center),
Text(Resources.Loading)
Expand Down
10 changes: 5 additions & 5 deletions src/LoopbackManager.Shell/LoopbackManager.Shell.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,18 +56,18 @@
Microsoft.WindowsAppSDK.WinUI, so no WinUI XAML is pulled in: Sprout draws the UI itself. -->
<PackageReference Include="Microsoft.WindowsAppSDK.Foundation" Version="2.1.0" />

<PackageReference Include="Sprout" Version="0.1.0-local.ga30846f334fb" />
<PackageReference Include="Sprout.Backend.D2D" Version="0.1.0-local.ga30846f334fb" />
<PackageReference Include="Sprout" Version="0.1.0-local.g449353c3d1e0" />
<PackageReference Include="Sprout.Backend.D2D" Version="0.1.0-local.g449353c3d1e0" />

<!-- The standalone Fluent System Icons package: Icon.Fluent(FluentSymbol.X, …) leaves (namespace Sprout.Controls). -->
<PackageReference Include="Sprout.FluentIcon" Version="0.1.0-local.ga30846f334fb" />
<PackageReference Include="Sprout.FluentIcon" Version="0.1.0-local.g449353c3d1e0" />

<!-- The Sprout to WinRT interop glue (Foundation-only, no WinUI): window.GetWindowId() / window.CreateFileOpenPicker()
/ picker.InitializeWithWindow(window), bridging a Sprout window to the Windows App SDK window handles. -->
<PackageReference Include="Sprout.WindowsAppSDK" Version="0.1.0-local.ga30846f334fb" />
<PackageReference Include="Sprout.WindowsAppSDK" Version="0.1.0-local.g449353c3d1e0" />
<!-- Opt-in MSIX packaging: `dotnet publish -r win-x64` then also produces a signed .msix (the self-contained
WinAppSDK runtime is bundled inside it). No Windows App SDK MSIX tooling — the same Sprout packer is used. -->
<PackageReference Include="Sprout.Packaging" Version="0.1.0-local.ga30846f334fb" />
<PackageReference Include="Sprout.Packaging" Version="0.1.0-local.g449353c3d1e0" />
</ItemGroup>

</Project>
Loading