Skip to content

Attribute Select: read attributes from Roam's new attributes model - #538

Open
panterarocks49 wants to merge 1 commit into
RoamJS:mainfrom
panterarocks49:attribute-select-harc-model
Open

Attribute Select: read attributes from Roam's new attributes model#538
panterarocks49 wants to merge 1 commit into
RoamJS:mainfrom
panterarocks49:attribute-select-harc-model

Conversation

@panterarocks49

Copy link
Copy Markdown

Roam's upcoming attributes revamp replaces :entity/attrs / :attrs/lookup with harc entities, and the migration retracts the old data, so the attribute list query in the Attribute Select config panel comes back empty. This swaps it for the one-clause equivalent on the new model:

[_ :harc/a ?page]

Same result shape, so the surrounding code is untouched. Bumps to 1.8.3 with a changelog entry.

Tested end to end in a Roam dev build on the new model: "Add Attribute" lists the graph's attributes, the dropdown renders next to Attr:: blocks, and selecting a value rewrites the block. Proxy attributes (roam/meta, opt-in proxies) never create harcs, so they no longer appear in the list, which is fine for a value picker.

Please hold the release until the Roam release that ships the new model is out; before that the list would be empty for hosted graphs.

https://claude.ai/code/session_01R2JbnyYCXWKHUQxh2FLZbn

Roam's attributes revamp replaces :entity/attrs and :attrs/lookup with
harc entities, and the migration retracts the old data. The attribute
list query in the config panel now reads attribute pages off :harc/a.

Claude-Session: https://claude.ai/code/session_01R2JbnyYCXWKHUQxh2FLZbn
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: 5ecfc2f2-ddac-4571-aab9-15fa5c1d47f2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mdroidian

Copy link
Copy Markdown
Collaborator

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

"esbuild": "0.17.14",
"patch-package": "^6.5.0",
"tailwindcss": "3.3.2",

P2 Badge Restore the omitted build peer packages

The regenerated lock still declares esbuild here, but it removes the corresponding node_modules/esbuild entry along with React, ReactDOM, Blueprint, Tailwind, and over a thousand peer/transitive package records that were present previously. In a clean install using the legacy peer layout under which this lock was generated (npm ci --legacy-peer-deps --dry-run), npm plans only 168 packages and omits those modules; the repository directly imports React/Blueprint and samepage build requires this toolchain, so such an install cannot build the extension. Regenerate the lock without dropping peer dependencies, or declare the required build/runtime packages directly.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-07T03:36:00.760206Z 1f9028c Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mdroidian

Copy link
Copy Markdown
Collaborator

@panterarocks49 Looks good! Thanks for the PR.

One thing before accepting, the package-lock is quite large. Could you try deleting it and running npm i? Generally there's like 5-6 lines of change on a version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants