Attribute Select: read attributes from Roam's new attributes model - #538
Attribute Select: read attributes from Roam's new attributes model#538panterarocks49 wants to merge 1 commit into
Conversation
Roam's attributes revamp replaces :entity/attrs and :attrs/lookup with harc entities, and the migration retracts the old data. The attribute list query in the config panel now reads attribute pages off :harc/a. Claude-Session: https://claude.ai/code/session_01R2JbnyYCXWKHUQxh2FLZbn
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review |
💡 Codex ReviewLines 78 to 80 in 1f9028c The regenerated lock still declares ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@panterarocks49 Looks good! Thanks for the PR. One thing before accepting, the package-lock is quite large. Could you try deleting it and running |
Roam's upcoming attributes revamp replaces
:entity/attrs/:attrs/lookupwith harc entities, and the migration retracts the old data, so the attribute list query in the Attribute Select config panel comes back empty. This swaps it for the one-clause equivalent on the new model:Same result shape, so the surrounding code is untouched. Bumps to 1.8.3 with a changelog entry.
Tested end to end in a Roam dev build on the new model: "Add Attribute" lists the graph's attributes, the dropdown renders next to
Attr::blocks, and selecting a value rewrites the block. Proxy attributes (roam/meta, opt-in proxies) never create harcs, so they no longer appear in the list, which is fine for a value picker.Please hold the release until the Roam release that ships the new model is out; before that the list would be empty for hosted graphs.
https://claude.ai/code/session_01R2JbnyYCXWKHUQxh2FLZbn