Avoid bounds checks in array intersection loops - #551
Merged
lemire merged 2 commits intoAug 19, 2026
Conversation
Member
|
Really impressive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes repeated input bounds checks from the local two-pointer array intersection loops.
Type of Change
Changes Made
What was changed?
AndandAndCardinality.localintersect2by2andlocalintersect2by2Cardinality.Why was it changed?
How was it changed?
Testing
go test ./...Checks: 1 passed.
Formatting
gofmt -w setutil.go setutil_test.goFuzzing
Not run; the change only restructures the existing sorted-slice intersection loop.
Performance Impact
The benchmarks use public operations on four aligned 4096-element array containers with alternating half-overlap. They cover the comparable-size array path, not galloping or non-array intersections.
Workload:
roaring.And across four aligned 4096-element array containers with alternating half-overlapns/opWorkload:
Bitmap.AndCardinality across four aligned 4096-element array containers with alternating half-overlapns/opRunning Benchmarks
go test -bench='^BenchmarkArrayIntersection$' -benchmem -run='^$'go test -bench='^BenchmarkArrayIntersectionCardinality$' -benchmem -run='^$'Performance Analysis
The compiler retains the output-buffer check but removes input bounds checks from the hot loops.
Breaking Changes
None.
Related Issues
None.
Additional Notes
None.
Generated by Perfloop. Measurements and checks.