Conversation
Roarpeng
marked this pull request as ready for review
September 7, 2026 08:05
… passes The join import already landed on main; scheduled Security Audit now reaches npm audit and fails on MCP SDK / transformers transitives. Override hono, @hono/node-server, body-parser, fast-uri, ip-address, qs, and sharp to patched versions. Direct deps unchanged.
cursor
Bot
force-pushed
the
cursor/fix-security-audit-join-aad7
branch
from
September 14, 2026 08:41
0f28941 to
51525b1
Compare
cursor
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Monday’s scheduled Security Audit on
main(4fa9b3f, run 34823757389) now runsnpm audit(thejoincrash was already fixed on main) and fails with 8 production findings (4 high, 3 moderate, 1 low), all transitives of@modelcontextprotocol/sdk/@huggingface/transformers.This PR was rebased onto current
main. The script/test work from the earlier revision is already shipped; this revision only adds npmoverrides.Changes
package.json/ lockfile overrides:@hono/node-serverhonobody-parserfast-uriip-addressqssharpDirect dependencies are unchanged. Default embeddings remain FNV;
sharp@0.35.4is above transformers’^0.34.5.Validation
npm run security:audit -- --json— exit 0npx vitest run tests/security-audit-script.test.ts— pass