Skip to content

fix(test): M83 walkFiles path assertions on Windows - #46

Open
Roarpeng wants to merge 2 commits into
mainfrom
cursor/fix-m83-windows-paths-aad7
Open

Roarpeng wants to merge 2 commits into
mainfrom
cursor/fix-m83-windows-paths-aad7

Conversation

@Roarpeng

Copy link
Copy Markdown
Owner

Why

main @ c46a9d7 (v1.18.3) failed validate-platforms (windows-latest):

tests/m83-index-scan-budget.test.ts
  expected [ Array(1) ] to deeply equal [ 'src/app.ts' ]
  + "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\gf-m83-nogit-...\\src\\app.ts"

walkFiles returns absolute paths. The tests stripped root + "/", which never matches root + "\\" on Windows, so the assertion saw the full path.

Changes

Use the same conversion as walkScannableFiles: normalizePath(relative(root, absPath)). No walker API change.

Note

One Build run also failed validate (ubuntu-latest, 20) with ERR_IPC_CHANNEL_CLOSED. That looks like the new index worker-pool flake, not this path bug; other CI runs on the same commit had ubuntu-20 green.

Validation

npx vitest run tests/m83-index-scan-budget.test.ts — 6 passed (Linux). Windows coverage is the CI job this PR is for.

Open in Web Open in Cursor 

walkFiles returns absolute paths. Stripping root + "/" left the full
Windows path (C:\...\src\app.ts) and failed validate-platforms.
Use the same normalizePath(relative()) as walkScannableFiles.
@Roarpeng
Roarpeng marked this pull request as ready for review September 13, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants