Conversation
v1.18.6 m87 asserted command === "npx". On Windows, resolveWindowsNpxLaunch writes node.exe plus npx-cli.js, same as Cursor/Claude/Codex. Assert the package args instead so validate-platforms can pass.
Roarpeng
marked this pull request as ready for review
September 14, 2026 12:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
main@7f74600(v1.18.6) failedvalidate-platforms (windows-latest):Windows MCP install uses
resolveWindowsNpxLaunch:node.exe+npx-cli.js+-y --package=@roarpeng/graphflow graphflow-mcp(same as Cursor/Claude/Codex). The new ZCode test hardcoded Unixnpx.Changes
Assert
commandis present and that the last three args are still-y --package=@roarpeng/graphflow graphflow-mcp. No installer behavior change.Validation
npx vitest run tests/m87-zcode-host.test.ts— 3 passed (Linux). Windows coverage is the CI job this unblocks.