fix: size status-light stale threshold to observed prober cadence - #2486
Merged
Conversation
The 30-minute stale threshold was set against the interval the GitHub Action *requests* (*/15) rather than what it delivers. Measured across 20 consecutive runs on this repo, the gaps were 30-71 minutes (median 46) -- every single interval exceeded the threshold, so gannet and klone spent most of each cycle rendering "unknown" despite being reachable the whole time. Raises the threshold to 90 minutes, which clears the worst observed gap with headroom, and corrects the page text, which claimed checks run every 10-15 minutes. This mainly matters while the GitHub Action is the only prober. Once the in-network cron is running every 10 minutes it becomes the freshest source and the ceiling stops mattering in practice -- so the real fix is still to set that cron up (see scripts/README.md). Verified against the live published status: at 45 minutes old, gannet and klone now render up rather than unknown; a 95-minute-old reading with up:true still correctly renders unknown, so a genuinely dead prober is still visible. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2484.
The problem
The status lights were spending most of each cycle showing
unknowneven though gannet and klone were reachable the whole time.I set the 30-minute stale threshold against the interval the GitHub Action requests (
*/15) rather than what GitHub actually delivers. Measured across the last 20 runs on this repo:Every single interval blew through the threshold. The lights were green for 30 minutes after each run landed, then grey for the remaining ~16 minutes on average, and up to 41 minutes in the worst gap.
The change
scripts/README.mdso the next person to touch the threshold knows what it is sized against.Verification
Built locally and pointed at the live published status data:
up, with raven correctlyunknownsince no in-network prober exists yet.up: truestill rendersunknown, so a genuinely dead prober remains visible rather than silently reporting everything green.Caveat
This is a mitigation, not the real fix. It buys tolerance for a slow backstop prober; it does not make the data fresher, and a dead prober now takes 90 minutes to surface instead of 30. Once the in-network cron is running every 10 minutes it becomes the freshest source, the merge logic prefers it, and this ceiling stops mattering in practice. Raven will keep reading
unknownuntil then — setup steps are inscripts/README.md.🤖 Generated with Claude Code