feat(ledger): native chart surface — initialize from a template, sever a connection - #210
Merged
Merged
Conversation
…r a connection Regenerated against robosystems main after #1378 and #1379: the initialize-chart-of-accounts operation with its request, response and template enum; disposition=disconnect|sever on deleteConnection; the chartTemplates GraphQL field with a ListChartTemplates query document and its typed model. Swept in from the same main: SearchRequest.snippet_chars (#1376) and the event_category doc text on EventBlockEnvelope. Facade: LedgerClient.list_chart_templates(graph_id) and LedgerClient.initialize_chart_of_accounts(graph_id, template, entity_type, name) beside initialize_ledger, with tests. Claude-Session: https://claude.ai/code/session_0188CbjDiNBtxdEYjSJ5Y7mX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerated against
robosystemsmain after RoboFinSystems/robosystems#1378 (native accounting cutover) and #1379 (chart templates as data), and adds the facade methods for the fresh-company chart path. Additive throughout; rides a client minor.Changes
Generated (OpenAPI)
api/extensions_robo_ledger/initialize_chart_of_accounts.pywithInitializeChartOfAccountsRequest,InitializeChartOfAccountsRequestTemplate(saas/services/product),InitializeChartOfAccountsResponse(incl.frameworks) and itsOperationEnvelope[...].api/connections/delete_connection.pygains thedispositionquery parameter (DeleteConnectionDisposition:disconnectdefault,severfor the QuickBooks → native cutover).SearchRequest.snippet_chars(#1376) and theevent_categorydoc text onEventBlockEnvelope.Generated (GraphQL)
schema.graphqlrefreshed:chartTemplates: [ChartTemplate!]!on the ledger query.operations/ledger/ListChartTemplates.graphqland its ariadne-codegen modelListChartTemplates/ListChartTemplatesChartTemplates;LIST_CHART_TEMPLATES_GQLexported.Facade (
clients/ledger_client.py)LedgerClient.list_chart_templates(graph_id) -> list[ChartTemplate].LedgerClient.initialize_chart_of_accounts(graph_id, template, *, entity_type=None, name=None) -> InitializeChartOfAccountsResponse, besideinitialize_ledger. Unknown template keys raiseValueErrorclient-side.Tests (
tests/test_ledger_client.py):TestChartOfAccountsOpscovers the GraphQL read, the operation call and body, and the unknown-template rejection.Compatibility
ADDITIVE — stable tier untouched (facades only gain methods; nothing the integration template imports changes). Generated tier: a new operation, a new optional query parameter on
delete_connection(defaulting to today's behaviour), a new GraphQL field, one new optional request field. Compared the emitted models: no field became required, nothing was removed or renamed. Client minor.Testing
just lint,just typecheck: clean.uv run pytest: 591 passed, 17 skipped (the pre-commit gate ran the same).robosystemsmain at29db598fwithgit log origin/main ^HEADempty first, per the regen rule.🤖 Generated with Claude Code
https://claude.ai/code/session_0188CbjDiNBtxdEYjSJ5Y7mX