✨ feat(minestom): add Minestom platform support and update version to… - #401
Merged
Conversation
… 3.35.0 - introduce MinestomSurfPlugin and MinestomSurfExtension for Minestom integration - add MinestomSpongeConfigSerializer for configuration serialization - update version in gradle.properties to 3.35.0 - include Minestom dependencies in build.gradle.kts
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an initial Minestom platform integration to SURF-API (new Minestom module + Gradle plugin wiring), and bumps the project version to 3.35.0 to ship the new platform artifact.
Changes:
- Introduce
surf-api-minestomwith Minestom plugin entrypoint, aSurfApiCoreservice implementation, and Sponge configurate serializer registration. - Extend the Gradle plugin to support a new
minestomplatform (new platform enum value + new Gradle plugin id). - Update versions/coordinates (project version to 3.35.0; add Minestom dependency to the version catalog).
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| surf-api-minestom/src/main/kotlin/dev/slne/surf/api/minestom/SurfApiMinestomPlugin.kt | Registers the Minestom plugin via @AutoService and Minestom metadata. |
| surf-api-minestom/src/main/kotlin/dev/slne/surf/api/minestom/SurfApiMinestomEntrypoint.kt | Minestom lifecycle entrypoint bootstrapping Surf + PacketEvents initialization. |
| surf-api-minestom/src/main/kotlin/dev/slne/surf/api/minestom/impl/SurfMinestomInstance.kt | Minestom CoreInstance singleton. |
| surf-api-minestom/src/main/kotlin/dev/slne/surf/api/minestom/impl/SurfMinestomApiImpl.kt | Minestom implementation of SurfApiCore registered via ServiceLoader. |
| surf-api-minestom/src/main/kotlin/dev/slne/surf/api/minestom/impl/MinestomSpongeConfigSerializer.kt | Registers Minestom Sponge/Configurate serializers via ServiceLoader. |
| surf-api-minestom/build.gradle.kts | Build definition for the new Minestom module and its dependencies. |
| surf-api-gradle-plugin/src/main/kotlin/dev/slne/surf/api/gradle/platform/SurfApiPlatform.kt | Adds MINESTOM to platform dependency enum. |
| surf-api-gradle-plugin/src/main/kotlin/dev/slne/surf/api/gradle/platform/minestom/MinestomSurfPlugin.kt | New Gradle plugin implementation for Minestom platform projects. |
| surf-api-gradle-plugin/src/main/kotlin/dev/slne/surf/api/gradle/platform/minestom/MinestomSurfExtension.kt | New Gradle extension for Minestom platform configuration. |
| surf-api-gradle-plugin/build.gradle.kts | Publishes a new Gradle plugin id for Minestom and bumps plugin version. |
| settings.gradle.kts | Includes the new surf-api-minestom module. |
| gradle/libs.versions.toml | Adds Minestom lobby API dependency to the version catalog. |
| gradle.properties | Bumps SURF-API version to 3.35.0. |
Comment on lines
+20
to
+22
| override suspend fun stop() { | ||
| SurfMinestomInstance.onDisable() | ||
| } |
Comment on lines
+6
to
+7
| @AutoService(SpongeConfigSerializers::class) | ||
| internal class MinestomSpongeConfigSerializer : SpongeConfigSerializers() No newline at end of file |
Comment on lines
+80
to
+82
| # Minestom | ||
| surf-minestom-lobby-api = { module = "dev.slne.minestom.lobby:surf-minestom-lobby-api", version = "+" } | ||
|
|
Comment on lines
+1
to
+13
| plugins { | ||
| `core-convention` | ||
| `api-validation` | ||
| } | ||
|
|
||
| dependencies { | ||
| api(projects.surfApiCore.surfApiCore) { | ||
| exclude(libs.commandapi.core) | ||
| exclude(libs.brigadier) | ||
| } | ||
|
|
||
| implementation(projects.surfApiCore.surfApiCoreServer) | ||
| compileOnlyApi(libs.surf.minestom.lobby.api) |
Comment on lines
21
to
25
| group = groupId | ||
| version = buildString { | ||
| append("2.0.8") | ||
| append("2.1.0") | ||
| if (snapshot) append("-SNAPSHOT") | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… 3.35.0