Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the Arctis 7+ family, sidetone, inactive time and equalizer changes were lost whenever the headset was power-cycled, because the driver never sent a save. This adds a saveStateArctis7Plus() helper that sends 00 09 (the same save opcode and pattern steelseries_arctis_nova_3p_wireless.hpp already uses) - called in each of the four setters.
Tested on an Arctis 7X+ (1038:2216): sidetone, EQ preset, custom EQ and inactive time all survive a power-cycle with this change. The other 7+ product IDs (220e, 2212, 2236) are untested, but they are the same hardware generation so I suspect the fix is identical / works on all. Each set now writes to flash (which may matter to anyone calling these from a timer, as I was doing previously). There already appears to be precedent in the code that save-after-set is an approved idiom, however.