fix(android): preserve session cookies during login - #169
Open
abdulnourwa wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I reproduced the Android login failure reported in #144 against a self-hosted server behind an HTTPS reverse proxy.
The server was returning a valid session cookie, but the Android client required the
Set-Cookieheader to be readable from JavaScript and then copied that response header into the next request. React Native already stores response cookies in Android's native cookie jar, so login should use that stored cookie directly.This change:
Set-Cookiecheck and manualCookieheaderWaiting for cookie removal also prevents an unfinished cleanup operation from deleting a newly created login session.
Testing
Fixes #144