-
Notifications
You must be signed in to change notification settings - Fork 249
[Klaud Cold] kimik2.5-fp4-b300-vllm: nightly image, TP/DEP/TEP sweep / Kimi K2.5 NVFP4 B300 nightly 镜像,TP/DEP/TEP 扫描 #2513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
f8a7c64
3b6a21f
7355453
a9b7787
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1529,7 +1529,7 @@ kimik2.5-fp4-b200-vllm: | |
| # does not have a B300-specific recipe, so this config reuses the existing | ||
| # Kimi-K2.5 FP4 B200 vLLM recipe as-is until B300-specific tuning is available. | ||
| kimik2.5-fp4-b300-vllm: | ||
| image: vllm/vllm-openai:v0.22.0 | ||
| image: vllm/vllm-openai:nightly-e2fa28594f7baad142a426b0b6a2cfe2c79201c7 | ||
| model: nvidia/Kimi-K2.5-NVFP4 | ||
| model-prefix: kimik2.5 | ||
| runner: b300 | ||
|
|
@@ -1541,9 +1541,11 @@ kimik2.5-fp4-b300-vllm: | |
| - isl: 8192 | ||
| osl: 1024 | ||
| search-space: | ||
| - { tp: 8, ep: 1, conc-start: 1, conc-end: 4 } | ||
| - { tp: 4, ep: 1, conc-start: 1, conc-end: 128 } | ||
|
|
||
| - { tp: 8, ep: 1, conc-list: [1] } | ||
| - { tp: 4, ep: 1, conc-start: 1, conc-end: 512 } | ||
| - { tp: 8, ep: 8, dp-attn: false, conc-list: [1] } | ||
| - { tp: 4, ep: 4, dp-attn: false, conc-start: 1, conc-end: 512 } | ||
| - { tp: 4, ep: 4, dp-attn: true, conc-start: 128, conc-end: 512 } | ||
|
Comment on lines
1543
to
+1548
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 The PR description says a DEP8 arm was added, but the only Extended reasoning...What's mismatched: The PR description states the sweep adds "TP8 (conc-1 only), TP4, TEP8, TEP4, and DEP8 arms," but the actual - { tp: 8, ep: 1, conc-list: [1] } # TP8
- { tp: 4, ep: 1, conc-start: 1, conc-end: 512 } # TP4
- { tp: 8, ep: 8, dp-attn: false, conc-list: [1] } # TEP8
- { tp: 4, ep: 4, dp-attn: false, conc-start: 1, conc-end: 512 } # TEP4
- { tp: 4, ep: 4, dp-attn: true, conc-start: 128, conc-end: 512 }# labeled DEP8 in the PR body, but tp:4/ep:4Why this is DEP4, not DEP8: In this repo's convention, when Step-by-step proof:
Why nothing prevents this / why it isn't blocking: All 5 arms are valid, well-formed configs and will run correctly regardless of their label — the mismatch is purely between the PR's free-text description and the committed YAML, not a functional defect. The committed Suggested fix: Reconcile the PR description with the config — either correct "DEP8" to "DEP4" in the description, or, if full-node (8-GPU) attention-DP throughput data was actually intended, add a |
||
| dsr1-fp8-b200-sglang-mtp: | ||
| image: lmsysorg/sglang:v0.5.12-cu130 | ||
| model: deepseek-ai/DeepSeek-R1-0528 | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 The header comment (lines 3-5) still says this script 'reuses the existing Kimi-K2.5 FP4 B200 vLLM recipe as-is until B300-specific tuning is available,' but this PR adds substantial B300-specific tuning (DP-attention/EP parallel arms,
--attention-config,--linear-backend flashinfer_cutlass, CONC-scaled cudagraph capture, new VLLM env vars) that has no counterpart inkimik2.5_fp4_b200.sh. Please update or remove the comment (and the matching NOTE above thekimik2.5-fp4-b300-vllmentry inconfigs/nvidia-master.yaml) so future readers don'''t assume this is an unmodified B200 clone.Extended reasoning...
The top-of-file comment in
benchmarks/single_node/fixed_seq_len/kimik2.5_fp4_b300.sh(lines 3-5) reads:That comment predates this PR and was accurate when the B300 script really was a byte-for-byte copy of the B200 recipe. This PR is precisely the 'B300-specific tuning' the comment says is still pending, so its own premise is now false.
Diff against
kimik2.5_fp4_b200.sh: I compared the two scripts directly. The B200 script has a fixed--tensor-parallel-size $TP, no DP-attention/EP arm selection, no--attention-config, no--linear-backend, no--prefill-schedule-interval, a fixed--max-cudagraph-capture-size 2048,--stream-interval 20, and none ofVLLM_USE_V2_MODEL_RUNNER,VLLM_FLASHINFER_AUTOTUNE_SKIP_OPS, orVLLM_RPC_TIMEOUT. This PR adds all of the following to the B300 script that have no B200 counterpart:PARALLEL_ARGS/GMU/PREFILL_SCHEDULE_ARGSlogic that switches between plain TP and DP-attention (TP=1, DP=$TP) with a lower GMU (0.85) and--prefill-schedule-interval 4(lines 19-25)EP_ARGStoggling--enable-expert-parallelwhenEP_SIZE > 1(lines 27-30)VLLM_USE_V2_MODEL_RUNNER=0,VLLM_FLASHINFER_AUTOTUNE_SKIP_OPS="",VLLM_RPC_TIMEOUT=600000(lines 55-57)--kv-cache-dtype fp8,--max-cudagraph-capture-size $((CONC * 2)),--stream-interval 32,--attention-config '{"mla_prefill_backend":"FLASHINFER","use_prefill_query_quantization":true}',--linear-backend flashinfer_cutlass(lines 79-83)Step-by-step proof:
kimik2.5_fp4_b300.shand read lines 3-5: a maintainer unfamiliar with the file's history would conclude the launch command is identical tokimik2.5_fp4_b200.sh.kimik2.5_fp4_b200.shand grep forattention-config,linear-backend,PARALLEL_ARGS,EP_ARGS,VLLM_RPC_TIMEOUT— none exist.vllm serveinvocations: the B300 one has 5+ flags/env-vars absent from B200, plus different values for--max-cudagraph-capture-sizeand--stream-interval.The identical stale wording also appears in the NOTE directly above the
kimik2.5-fp4-b300-vllmblock inconfigs/nvidia-master.yaml(around line 1436), so both spots should be updated together.Impact: none functionally — the sweep script runs correctly regardless of the comment's wording. This is purely a documentation-accuracy issue: a future engineer reading the comment could be misled into thinking any B200-recipe change should be mirrored here without modification, or that this script has no independent tuning worth preserving/reviewing on its own. Fix is trivial: replace the comment with something like 'B300-specific tuning: DP-attention/EP parallel-arm selection, attention-config/linear-backend overrides, and cudagraph/env-var tuning added below' or simply delete the now-inaccurate 'as-is' framing.