Make payments extension capability fields optional - #8147
Merged
Conversation
Shuhala
force-pushed
the
optional-payments-support-flags
branch
from
July 22, 2026 15:07
145e63e to
12c4b02
Compare
Shuhala
marked this pull request as ready for review
July 22, 2026 15:08
Shuhala
force-pushed
the
optional-payments-support-flags
branch
3 times, most recently
from
July 23, 2026 14:14
e878dcd to
59e8ba8
Compare
Shuhala
changed the title
Shuhala
force-pushed
the
optional-payments-support-flags
branch
4 times, most recently
from
July 24, 2026 15:41
6b9cde2 to
d2b11b8
Compare
Shuhala
changed the title
dmerand
approved these changes
Jul 28, 2026
dmerand
left a comment
dmerand
left a comment
Contributor
There was a problem hiding this comment.
LGTM overall, just one question about test coverage.
Contributor
There was a problem hiding this comment.
Could you confirm whether supports_installments and supports_deferred_payments may be omitted independently? The schema still rejects configs where only one is missing; the new tests cover only both being omitted. If the pair must remain synchronized, please add a test documenting that contract.
Contributor
Author
There was a problem hiding this comment.
Yes they can be optional independently. Neither of these fields is actually used.
Assisted-By: devx/662f85f5-a0c5-4b77-b4e3-a07404abaf08
Shuhala
force-pushed
the
optional-payments-support-flags
branch
from
July 28, 2026 19:53
d2b11b8 to
fe42739
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes
supports_installments,supports_deferred_payments, andsupports_3dsoptional in payments app extension TOML config schemas, so partners can omit them.supports_3dsstays required forcredit_cardandcustom_credit_cardextensions.Why
Companion to the core change in shop/world#940396 that relaxed the same properties on the server side. Without this CLI-side change,
shopify app deployrejects configs that omit these fields even though core now accepts them.