Link schema hover to the model's table definition - #730
Open
yoshiyoshiharu wants to merge 1 commit into
Open
Conversation
Author
|
I have signed the CLA! |
yoshiyoshiharu
force-pushed
the
schema-hover-link-to-table-location
branch
from
September 6, 2026 02:15
c11de2d to
487c74f
Compare
The "Schema" link in hover now jumps straight to the model's create_table block in schema.rb instead of just the top of the file, using a Prism visitor to locate it by table name. Falls back to the plain file link for structure.sql or when the table can't be found. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
yoshiyoshiharu
force-pushed
the
schema-hover-link-to-table-location
branch
from
September 6, 2026 02:21
487c74f to
4bce439
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #52.
The
Schemalink in a model's hover opensdb/schema.rbat the top, so you still have to find thetable yourself. This makes it jump to the model's
create_tableblock.This was already being worked on in #212, which takes a similar approach. That PR is still open but
has had no activity since March 2024, so rather than leave the issue sitting I put together a fresh
implementation. Happy to close this in favour of #212 if it's still moving.