Publish debug symbols on release - #666
Merged
Merged
Conversation
…lease Release builds now keep line tables through the link (CARGO_PROFILE_RELEASE_DEBUG=1 + STRIP=none, overriding the profile's debug=false/strip=debuginfo); PR/push builds keep the profile defaults. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #666 +/- ##
=======================================
Coverage 76.83% 76.83%
=======================================
Files 31 31
Lines 2612 2612
=======================================
Hits 2007 2007
Misses 605 605 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR extends the Rust release workflow to publish debug symbols to symbols.sierrasoftworks.com on GitHub Releases using OIDC authentication, while ensuring release builds retain line tables for symbolization.
Changes:
- Adds an explicit job
permissionsblock to enable OIDCid-tokenusage and allow release asset uploads. - Overrides Cargo release-profile settings during
releaseevents to keep line tables and avoid stripping at link time. - Adds a
SierraSoftworks/symbols@v1step to upload symbols on release builds.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+98
to
+104
| # id-token lets the symbols action authenticate to the symbol server with | ||
| # this workflow's OIDC identity; contents stays writable for the release | ||
| # asset upload (an explicit permissions block replaces the defaults). | ||
| permissions: | ||
| contents: write | ||
| id-token: write | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publishes debug symbols to symbols.sierrasoftworks.com on every release via SierraSoftworks/symbols@v1, following the pattern established in grey (SierraSoftworks/grey#1151, #1152). Uploads authenticate with the workflow's OIDC id-token (no secrets); the server derives the build ID from the file itself and auto-creates the project from the token's repository claim. On Linux/macOS the action re-strips the binary after splitting, so release assets keep their usual size.
Release builds now keep line tables through the link (CARGO_PROFILE_RELEASE_DEBUG=1 + STRIP=none, overriding the profile's debug=false/strip=debuginfo); PR/push builds keep the profile defaults.
🤖 Generated with Claude Code