Updated overlay to use new circle feature available in EDMCModernOverlay - #57
Open
SweetJonnySauce wants to merge 1 commit into
Open
Updated overlay to use new circle feature available in EDMCModernOverlay#57SweetJonnySauce wants to merge 1 commit into
circle feature available in EDMCModernOverlay#57SweetJonnySauce wants to merge 1 commit into
Conversation
…erlay v0.9.2. Will gracefully fall back to old version if 1) overlay is not `modern_overlay` and 2) if version of EDMCMO is <0.9.2 (via type error).
Owner
|
I'm fine with this in general, though I may take a look at the import stuff a bit. Can you migrate the circle code to a standalone function so we have less bloat in the main render function? |
Author
|
Yeah, I can do that. |
Owner
|
@SweetJonnySauce Any progress on this? |
Author
|
Sorry no. IRL stuff and I prioritized getting a surface mining beta out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EDMCModernOverlay v0.9.2+ now has the
send_shape(shape='circle'...)feature (pre-release version here).This PR checks to see if the overlay is
modern_overlay(existing check) and then checks to makes sure the version is compatible (via type error onradiusargument). If it's compatible, it'll use the newsend_shape(shape='circle'...)feature and if not, it falls back to the old vector circle.It also updates
available()to try a lazy re-import of EDMCModernOverlay via_connect_overlay()(I had an issue with it not loading due to EDMC loading order).