fix: green socket-cli main 🔎 Check (script paths, citations, action port map, coverage badge)#1437
Merged
Merged
Conversation
John-David Dalton (jdalton)
force-pushed
the
fix/check-green-script-paths
branch
from
July 26, 2026 22:00
7478fe1 to
2f5895b
Compare
…lobs The scripts/repo migration moved check.mts and update.mts into scripts/fleet/, but packages/cli/package.json still pointed its "check" and "update" scripts at the old ../../scripts/*.mts paths, failing check-script-paths-resolve. The lockstep-emit-mirror-globs.mts script cascaded in (and its sibling lockstep:emit-schema is wired), but the root package.json never got the matching lockstep:emit-mirror-globs alias, so the updating-lockstep skill docs cited a pnpm script that did not resolve, failing check-pnpm-run-citations-resolve. - packages/cli/package.json: check -> ../../scripts/fleet/check.mts - packages/cli/package.json: update -> ../../scripts/fleet/update.mts - package.json: add lockstep:emit-mirror-globs pointing at the existing scripts/fleet/lockstep-emit-mirror-globs.mts shim
…dge) Two fleet-drift 🔎 Check failures on main, independent of the script-path/citation fix: - action-ports-are-lock-stepped: the setup-go-toolchain composite had no port-map entry. Its action.yml states it is "written inline so we don't depend on a third-party action" and only borrows actions/setup-go's generic fallback ordering, porting neither its input surface nor its go.dev/dl download algorithm — so it is Socket-original (`[]`), not a lock-stepped port. - coverage-badge-is-current: the README carried a shields.io badge with a decimal percent (coverage-75.08%25) that the migrator's integer-only matcher could not recognize, tripping the unrecognized-form gate. Repointed to the canonical repo-local asset badges/coverage.svg (the generated placeholder SVG already exists and is tracked).
John-David Dalton (jdalton)
force-pushed
the
fix/check-green-script-paths
branch
from
July 26, 2026 22:11
2f5895b to
bd0da66
Compare
John-David Dalton (jdalton)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
main's🔎 Check(pnpm run check --all) is red, blocking every PR. This folds the fixable residuals into one landing. After this branch, the only remaining🔎 Checkfailure islint(see "Remaining blocker" below).Fixed here
check-script-paths-resolve—packages/cli/package.jsoncheck/updatepointed at the pre-migration../../scripts/*.mtspaths; repointed to../../scripts/fleet/*.mts.check-pnpm-run-citations-resolve— added the missing rootlockstep:emit-mirror-globsalias (the backingscripts/fleet/lockstep-emit-mirror-globs.mtsshim and itslockstep:emit-schemasibling already existed; only the alias was missing).action-ports-are-lock-stepped— added thesetup-go-toolchainport-map entry as Socket-original ([]). Itsaction.ymlsays it is "written inline so we don't depend on a third-party action"; it borrows onlyactions/setup-go's generic fallback ordering, porting neither its input surface nor its go.dev/dl download algorithm — so there is no upstream release to lock-step against.coverage-badge-is-current— the README carried a shields.io badge with a decimal percent (coverage-75.08%25) that the migrator's integer-only matcher couldn't recognize, tripping the unrecognized-form gate. Repointed to the canonical repo-local assetassets/repo/badges/coverage.svg(the generated placeholder SVG already exists and is tracked).Remaining blocker (not fixed here — rule-tier decision)
lintstill fails on the fleet oxlint rulesocket/no-required-in-options-bag: 114 violations across 24 files, all legitimate "required config bag" interfaces (CreatePrOptions,DispatchSubcommandOptions,SocketBasicsOptions,BuildCacheKeyOptions, git provider, subcommand dispatch/help, spawn, reachability, pipeline cache/types, update subsystem…). These are a common mature-CLI idiom (a config object with some mandatory fields), flagged purely on the*Optionsname suffix. Complying means either hoisting required members to positionals, renaming*Options→*Config+ making the param required (both reshape APIs + all call sites), or a blanket bypass sweep. That's a large/high-blast-radius change and a fleet rule-tier decision (warn-vs-error fleet-wide) — deferred to a maintainer rather than forced here.Do not merge until the
lintdecision lands and🔎 Checkis fully green.