fix(deps): bump the maven smoke fixture's commons-io past GHSA-78wr-2p64-hpwj (v1.x) - #1458
Closed
John-David Dalton (jdalton) wants to merge 1 commit into
Closed
fix(deps): bump the maven smoke fixture's commons-io past GHSA-78wr-2p64-hpwj (v1.x)#1458John-David Dalton (jdalton) wants to merge 1 commit into
John-David Dalton (jdalton) wants to merge 1 commit into
Conversation
…p64-hpwj Port of the main-branch fix to v1.x, whose copy of the fixture carries the same pin. commons-io 2.11.0 is in the vulnerable range for the XmlStreamReader denial-of-service advisory (>= 2.0, < 2.14.0); bumped to 2.22.0. The smoke test repeated that version in four places, so a pom-only bump would have left its assertions hunting for a jar the build no longer produces. The assertions now match on groupId:artifactId and ignore the version, and the scoped-materialization run derives its GAV from the records the first run emitted.
This was referenced Aug 1, 2026
Collaborator
Author
|
Closing — this change is already on the target branch. The fixture now pins The follow-up that replaces those external artifacts with generated stubs is still open and has been rebased so it no longer depends on this branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #1457 to
v1.x, which carries the same vulnerable pin.v1.xhas its own copy of the Maven smoke fixture atsrc/commands/manifest/scripts/test/maven-compat/, and itssmoke-test.shis byte-identical to main's. Both pinnedcommons-io2.11.0, which is in the vulnerable range for GHSA-78wr-2p64-hpwj (>= 2.0, < 2.14.0). Now 2.22.0.Worth saying why this is a separate PR rather than something to skip: Dependabot only scans the default branch, so its alert names main's path and this copy never showed up in the security tab. But
v1.xis actively committed to, so the same pin was sitting there unflagged.As on main, the version is no longer written in the test at all. The assertions match on
groupId:artifactIdand ignore the version, and the scoped-materialization run derives its GAV from the records the first run emitted, so the poms are the only place a version appears.Validation
bash -n smoke-test.shclean; no2.11.0remains anywhere in the fixture.mvn --batch-mode -Dmaven.repo.local=$(mktemp -d) compile): exits 0, resolvescommons-io-2.22.0.jarfrom Central.records.tsvinput: they pass on well-formed records, and still fail correctly when commons-io is absent ("missing external prod dep commons-io") and when a test dependency wrongly lands in a prod root.smoke-test.shcould not be run here because the Coana extension jar is "built elsewhere". That was wrong —scripts/maven-extension/build-jar.shbuilds it from this repo. The follow-up PR stacked on this branch runs the full smoke test end to end against that jar, and both phases pass.Note
Low Risk
Changes only affect the Maven smoke fixture and its shell assertions; no production manifest or extension logic is modified.
Overview
Bumps commons-io in the Maven compat smoke fixture
app/pom.xmlfrom 2.11.0 to 2.22.0, clearing GHSA-78wr-2p64-hpwj for the vulnerable>= 2.0, < 2.14.0range on thev1.xcopy of the fixture.smoke-test.shno longer pins dependency versions in assertions. Acoord(prefix)helper resolves emitted coordinate IDs bygroupId:artifactIdprefix, and the scopedpopulateFilesForrun builds its GAV list from the first run’srecords.tsvinstead of a hardcodedcommons-io:commons-io:2.11.0. Future pom-only version bumps (e.g. CVE fixes) should not require editing the shell test.Reviewed by Cursor Bugbot for commit 3dcaae0. Configure here.