Skip to content

fix(manifest): keep the Maven extension build out of the developer's home directory #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
John-David Dalton (jdalton) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(manifest): keep the Maven extension build out of the developer's home directory #1461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion packages/cli/src/commands/manifest/scripts/maven-extension/build-jar.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,18 @@
set -euo pipefail

here="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
( cd "$here" && ./mvnw -q --batch-mode package )

# Keep the downloaded artifacts and the Maven distribution out of the developer's ~/.m2. The path is
# stable so the plugin closure stays cached between runs; point SOCKET_CLI_MAVEN_HOME elsewhere for a
# cold build.
tmp_root="${TMPDIR:-/tmp}"
maven_home="${SOCKET_CLI_MAVEN_HOME:-${tmp_root%/}/socket-cli-maven-home}"
mkdir -p "$maven_home"

(
cd "$here"
MAVEN_USER_HOME="$maven_home" ./mvnw -q --batch-mode \
-Dmaven.repo.local="$maven_home/repository" package

@cursor cursor Bot Aug 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relative cache path cwd mismatch

Medium Severity

When SOCKET_CLI_MAVEN_HOME or TMPDIR is a relative path, mkdir -p uses the caller’s working directory, but MAVEN_USER_HOME and -Dmaven.repo.local are applied after cd into the extension directory, so Maven and the wrapper write to a different tree than the one created upfront.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2e7512b. Configure here.

)
cp -f "$here/target/coana-maven-extension.jar" "$here/coana-maven-extension.jar"
echo "Coana Maven extension jar: $here/coana-maven-extension.jar"
Loading