Skip to content

fix: Wrong message when comparing two sequences with alignment - #42

Open
dpinol wants to merge 1 commit into
Solganis:mainfrom
dpinol:fix-aligment-msg
Open

dpinol wants to merge 1 commit into
Solganis:mainfrom
dpinol:fix-aligment-msg

Conversation

@dpinol

@dpinol dpinol commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Fixes #41
When comparing 2 sequences that are the same except for an extra item at the beginning of one of them, there was a bug when reporting a compressed version of the sequence. It contained <[.., first item]>, where it displays the head item at the end rather than at the beginning.

Fixes Solganis#41
When comparing 2 sequences that are the same except for an extra item at the beginning of one of them, there was a bug when reporting a compressed version of the sequence. It contained <[.., first item]>, where it displays the head item at the end rather than at the beginning.
@codspeed

codspeed Bot commented Sep 17, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 10.83%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 42 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
test_polling_a_wide_value[recorder-off] 31.2 ms 35 ms -10.83%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing dpinol:fix-aligment-msg (7082c5c) with main (bbf6bf5)

Open in CodSpeed

@Solganis

Copy link
Copy Markdown
Owner

Thanks, @dpinol

I'am nearly on the end of a 2-week vacation and will check this PR and issues you created asap!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong message when comparing two sequences with alignment

2 participants