Skip to content

BED-9720 assign source kinds by node family - #73

Merged
jaredcatkinson merged 2 commits into
mainfrom
feature/BED-9720-source-kind-assignment
Sep 10, 2026
Merged

BED-9720 assign source kinds by node family#73
jaredcatkinson merged 2 commits into
mainfrom
feature/BED-9720-source-kind-assignment

Conversation

@jaredcatkinson

@jaredcatkinson jaredcatkinson commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove the global GitHub source kind assignment from the collector app
  • assign GitHub vs SAML source kinds centrally for GHNode-backed assets
  • assign SCIM source kinds for normalized SCIM nodes and remove the stale SCIM source_kind property

Testing

  • uv run pytest

Dependency

Summary by CodeRabbit

  • New Features

    • GitHub assets now include consistent GitHub source classification alongside their specific types.
    • SAML-related assets are automatically identified and categorized as SAML.
    • SCIM users, groups, and organizations now carry consistent SCIM classification.
  • Bug Fixes

    • Improved source-kind assignment for mixed GitHub and SAML data, resulting in more reliable asset categorization and filtering.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: b11bf8d3-4ad5-435c-8bdd-2076d7be6be3

📥 Commits

Reviewing files that changed from the base of the PR and between dc5db62 and 69fbcb7.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (7)
  • pyproject.toml
  • src/openhound_github/graph.py
  • src/openhound_github/main.py
  • src/openhound_github/models/scim_user.py
  • tests/test_runner_models.py
  • tests/test_saml_models.py
  • tests/test_scim_models.py

Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


Walkthrough

The change updates openhound, adds source-kind constants, assigns GitHub, SAML, and SCIM kinds during node initialization, removes redundant configuration, and updates model assertions.

Changes

Source-kind normalization

Layer / File(s) Summary
GitHub and SAML kind assignment
pyproject.toml, src/openhound_github/graph.py, src/openhound_github/main.py, tests/test_runner_models.py, tests/test_saml_models.py
The dependency requires openhound >=0.4.0. GHNode assigns GitHub or SAML source kinds. GitHub and SAML tests verify the resulting kinds.
SCIM kind assignment
src/openhound_github/models/scim_user.py, tests/test_scim_models.py
ScimNode assigns the SCIM kind. SCIM node construction removes the old source_kind property. Tests verify SCIM kinds.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 69fbc

This change assigns GitHub, SAML, and SCIM source kinds by node family and removes the stale SCIM source-kind property. The updated model assertions cover the intended kind assignments, with no identified merge-readiness risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 14 functions across 6 files. (1 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: assigning source kinds by node family.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 14 functions across 6 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/BED-9720-source-kind-assignment

A rabbit checks each node in line
GitHub and SAML kinds now shine
SCIM hops into place
Tests confirm the case
Clean labels make the graph align

Comment @coderabbitai help to get the list of available commands.

@JimSycurity JimSycurity left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need similar updates in other openhound extensions.

@jaredcatkinson
jaredcatkinson merged commit 0a0f555 into main Sep 10, 2026
3 checks passed
@jaredcatkinson
jaredcatkinson deleted the feature/BED-9720-source-kind-assignment branch September 10, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants