Skip to content

BED-9721 migrate GitHub entity panels into schema - #74

Merged
jaredcatkinson merged 3 commits into
mainfrom
feature/BED-9721-schema-entity-panels
Sep 10, 2026
Merged

BED-9721 migrate GitHub entity panels into schema#74
jaredcatkinson merged 3 commits into
mainfrom
feature/BED-9721-schema-entity-panels

Conversation

@jaredcatkinson

@jaredcatkinson jaredcatkinson commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • move GitHub node navigation queries into schema-defined entity panels
  • add direct traversable relationship summaries and investigation panels for core GitHub nodes
  • add dedicated enterprise, identity, and enterprise runner-group panels where generic inheritance was too lossy

Validation

  • python3 docs/og-docs-automation/skills/openhound-entity-panels/scripts/entity_panel_tool.py validate --schema extension/schema.json --allow-missing-panels
  • uv run pytest

Summary by CodeRabbit

  • Enhancements
    • Improved source classification for GitHub, SAML, and SCIM records.
    • GitHub and SAML entities now display consistent source labels alongside their specific types.
    • SCIM users, groups, and organizations now consistently identify as SCIM records.
    • Runner and runner-group records now include the GitHub classification.
  • Maintenance
    • Updated the OpenHound development tooling dependency.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 1a144cb1-1d4c-49c8-ae4a-389eb03672b3

📥 Commits

Reviewing files that changed from the base of the PR and between dc5db62 and 8c36e74.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (8)
  • extension/schema.json
  • pyproject.toml
  • src/openhound_github/graph.py
  • src/openhound_github/main.py
  • src/openhound_github/models/scim_user.py
  • tests/test_runner_models.py
  • tests/test_saml_models.py
  • tests/test_scim_models.py

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


Walkthrough

The change moves source-kind assignment into node models. GitHub and SAML nodes derive their source kind from node kinds. SCIM nodes add SCIM. Application wiring and tests now use the derived kinds.

Changes

Source-kind classification

Layer / File(s) Summary
GitHub and SAML source kinds
src/openhound_github/graph.py, src/openhound_github/main.py, tests/test_runner_models.py, tests/test_saml_models.py, pyproject.toml
GH nodes add GitHub or SAML based on their node kinds. Application initialization no longer sets source_kind. Tests verify the derived kinds.
SCIM source kind
src/openhound_github/models/scim_user.py, tests/test_scim_models.py
SCIM nodes add the shared SCIM kind. SCIM constructors no longer assign GitHub. Tests verify the updated kinds.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 8c36e

This change derives GitHub, SAML, and SCIM source classifications from node kinds and updates the corresponding model expectations. No concrete merge-blocking production risk is established.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 14 functions across 6 files. (1 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: migrating GitHub entity panels into the schema. The issue identifier does not obscure the scope.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 14 functions across 6 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/BED-9721-schema-entity-panels

A rabbit checks each node kind bright
GitHub and SAML sort themselves right
SCIM joins the trail
Tests watch without fail
Dependencies hop to a newer height

Comment @coderabbitai help to get the list of available commands.

@jaredcatkinson
jaredcatkinson merged commit 056c0f8 into main Sep 10, 2026
3 checks passed
@jaredcatkinson
jaredcatkinson deleted the feature/BED-9721-schema-entity-panels branch September 10, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants