Skip to content

Remove obsolete bundled agent skills - #129

Open
SunkenInTime wants to merge 1 commit into
icarus-cloudfrom
t3code/evaluate-p2p-online-mode
Open

Remove obsolete bundled agent skills#129
SunkenInTime wants to merge 1 commit into
icarus-cloudfrom
t3code/evaluate-p2p-online-mode

Conversation

@SunkenInTime

Copy link
Copy Markdown
Owner

Summary

  • Remove duplicated Convex and Impeccable skill bundles and related editor integrations.
  • Add the cloud branch context and server-side sync boundary handoff documents.
  • Update repository guidance and clean up generated skill metadata.

Testing

  • Not run; documentation and repository tooling changes only.

- Delete redundant Convex and UI skill packages from the repository
@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8b9a147d-e7bc-42f4-9115-63b02be2f2ee

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This change removes obsolete bundled agent/editor skills and generated Convex guidance, then adds repository-owned vocabulary and a page-scoped cloud-sync implementation and delivery guide.

The new documentation links resolve, and the TypeScript and diff-whitespace checks pass. However, the handoff’s required Flutter tests, analysis, and visible client launches cannot start because the documented fvm command is not available or bootstrapped.

Confidence Score: 3/5

Not ready to merge until the cloud-sync handoff provides an executable Flutter/FVM setup path or uses the repository-supported Flutter command.

The documented Flutter test, analysis, and launch commands were executed and consistently failed because fvm was unavailable. Repository-relative documentation links, TypeScript checking, and diff-whitespace checking succeeded, but the required Flutter and visible-client proof remains unavailable through the published instructions.

Files Needing Attention: docs/cloud_sync_refactor/server_side_sync_boundaries_handoff.md and docs/cloud_sync_refactor/server_side_sync_boundaries_delivery.md need a documented FVM/SDK bootstrap prerequisite or corrected Flutter invocations.

T-Rex T-Rex Logs

What T-Rex did

  • T-Rex produced a proof for a posted P1 finding and referenced the review comment for details.
  • T-Rex verified that every repository-relative link in the new handoff and delivery documents resolves, and ran independently executable TypeScript and diff-whitespace checks; both completed successfully.
  • T-Rex produced proof for a second posted P1 finding.
  • T-Rex evaluated the required command excerpts, runtime checks, repository evidence, and unrelated checks; the environment lacked fvm and flutter tools, causing key commands to be unavailable while unaffected checks passed.

View all artifacts

T-Rex Ran code and verified through T-Rex

Comments Outside Diff (1)

  1. General comment

    P1 Required FVM commands are not executable from the documented handoff

    • Bug
      • The new handoff and delivery runbook make fvm flutter commands mandatory for focused tests, the full Flutter gate, analysis, and visible-proof client launches. In the repository environment, neither fvm nor flutter is installed or discoverable, and all five exercised FVM commands exit 127 before any test, analysis, or app launch occurs. Contributors following the handoff cannot complete its required proof without undocumented setup.
    • Cause
      • docs/cloud_sync_refactor/server_side_sync_boundaries_handoff.md:95-101 and 355-362, and docs/cloud_sync_refactor/server_side_sync_boundaries_delivery.md:15-16, assume FVM is available but contain no installation/bootstrap prerequisite. The repository has .fvmrc declaring Flutter 3.41.1, while the captured README setup section only requires Flutter and documents plain flutter commands.
    • Fix
      • Add an explicit prerequisite before the baseline/gate commands that installs or bootstraps FVM and the .fvmrc SDK (or change the documented contract to the repository-supported flutter invocation and state the required SDK version). State the platform requirement separately for the macOS visible-proof client.

    T-Rex Ran code and verified through T-Rex

Reviews (1): Last reviewed commit: "Remove obsolete bundled agent skills" | Re-trigger Greptile

Comment on lines +95 to +101
fvm flutter test \
test/strategy_page_session_provider_test.dart \
test/strategy_op_queue_provider_test.dart \
test/collab_sync_models_test.dart \
test/cloud_ui_parity_helpers_test.dart \
test/strategy_integrity_test.dart
PASS, 55 tests

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Required FVM commands cannot run

The handoff makes fvm flutter mandatory for the focused tests, full Flutter suite, analyzer, and the delivery runbook’s macOS and Chrome clients, but it does not provide an FVM installation or SDK-bootstrap prerequisite. In the repository environment, both fvm and global flutter are unavailable, so each required command exits with fvm: not found before validation or a client launch begins. The repository has a local Flutter SDK and .fvmrc, but contributors following this new handoff have no documented way to make the required command available. Add an explicit FVM/bootstrap step or use the repository-supported Flutter invocation consistently.

T-Rex Ran code and verified through T-Rex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant