fix(ci): unbreak Signal Chain CI (fmt, clippy, windows shell) - #4
Merged
Merged
Conversation
Three independent root causes for the red main CI in Signal Chain CI: - `cargo fmt` job: openshell-signal-chain wasn't rustfmt-clean. Ran `cargo fmt -p openshell-signal-chain` (formatting only, no logic change). - test-ubuntu/test-macos: `cargo clippy` failed with "'cargo-clippy' is not installed for the toolchain" because the "Configure Rust" step never installs the clippy component. Added `rustup component add clippy`. - test-windows: the "Configure Rust" step uses bash-style `2>/dev/null` redirection but runs under the runner's default shell on Windows (pwsh), which tried to resolve /dev/null as a literal path and failed immediately. Added `shell: bash` so the step runs consistently across all three OSes. Verified locally: `cargo fmt -p openshell-signal-chain -- --check`, `cargo test -p openshell-signal-chain`, and `cargo clippy -p openshell-signal-chain -- -D warnings` all pass. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JV2C8fnD86DNwXoyHPd7X9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root causes (Signal Chain CI red on
mainsince 2026-08-31, run 33355653703)cargo fmtjob —openshell-signal-chainwasn't rustfmt-clean (mostly multi-line call-argument wrapping). Fixed by runningcargo fmt -p openshell-signal-chain; no logic changes.test-ubuntu/test-macos—cargo clippyfailed with'cargo-clippy' is not installed for the toolchain '1.95.0-...'. TheConfigure Ruststep never installs the clippy component. Addedrustup component add clippy.test-windows— theConfigure Ruststep'srustup target add ... 2>/dev/null || trueuses bash-style redirection but ran under the Windows runner's default shell (pwsh), which tried to resolve/dev/nullas a literal path (Could not find a part of the path 'D:\dev\null') and failed the whole step before any test ran. Addedshell: bashso the step behaves the same on all three OSes.Verification
Ran locally against the same crate/toolchain:
The
build-arm64job (cargo check only, no clippy) was already green and is untouched.Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01JV2C8fnD86DNwXoyHPd7X9
Generated by Claude Code