fix(just): clear stale Go coverage data before running tests - #209
Merged
Conversation
`go tool covdata` merges every covmeta in .output/<component>/coverage/data, and the directory is never cleared. Run the tests on one branch and then on another and the merged profile still names source files that only existed on the first, so `go tool cover -html` fails reading them — every spec passes and the target still goes red. Drop the directory before delegating to quitsh. The run about to happen regenerates all of it. CI gets a fresh workspace, so this only ever bit locally, after a branch switch. The proper fix is for quitsh's test-go runner to clear GOCOVERDIR itself, but that runner lives upstream in sdsc-ordes/quitsh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go tool covdatamerges every covmeta in.output/<component>/coverage/data, and the directory is never cleared. Run the tests on one branch and then on another and the merged profile still names source files that only existed on the first, sogo tool cover -htmlfails reading them — every spec passes and the target still goes red.Drop the directory before delegating to quitsh. The run about to happen regenerates all of it. CI gets a fresh workspace, so this only ever bit locally, after a branch switch.
The proper fix is for quitsh's test-go runner to clear GOCOVERDIR itself, but that runner lives upstream in sdsc-ordes/quitsh.