feat(frontend): add a participant detail page - #216
Open
sabinem wants to merge 1 commit into
Open
Conversation
The participants list is a name and a role chip, which is not enough to know who you are about to team up with. Each row gets a View link onto a profile page — the link ParticipantCard's `actions` snippet was always shaped for. No new RPC for identity: the hackathon layout already loads every member with their casbin role, waitlist flag and join date, so the page is a projection of a list the viewer has already been granted. Teams need TeamService.List, which gates on the same hackathon:read the layout just passed. Email is left off. User carries one, but it is shown only on the platform admin page today, never to a peer, and this page is readable by every confirmed member. A waitlisted id 404s rather than resolving, so the route cannot become a way around the list's own privacy filter. Sparse by necessity — affiliation, bio, avatar, skills and LinkedIn have nowhere to come from until User grows the fields (TODO(backend: user-profile-fields)). Nothing is stubbed for them: an empty About card would read as "this person filled nothing in" rather than "the platform cannot ask yet".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The participants list is a name and a role chip, which is not enough to know who you are about to team up with. Each row gets a View link onto a profile page — the link ParticipantCard's
actionssnippet was always shaped for.No new RPC for identity: the hackathon layout already loads every member with their casbin role, waitlist flag and join date, so the page is a projection of a list the viewer has already been granted. Teams need TeamService.List, which gates on the same hackathon:read the layout just passed.
Email is left off. User carries one, but it is shown only on the platform admin page today, never to a peer, and this page is readable by every confirmed member. A waitlisted id 404s rather than resolving, so the route cannot become a way around the list's own privacy filter.
Sparse by necessity — affiliation, bio, avatar, skills and LinkedIn have nowhere to come from until User grows the fields
(TODO(backend: user-profile-fields)). Nothing is stubbed for them: an empty About card would read as "this person filled nothing in" rather than "the platform cannot ask yet".