Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed

- Icon-only buttons announced as nothing by VoiceOver across the data grid, row inspector, editor find bar, filter bar, structure, dashboard and settings.
- Status icons that carried a result only as a symbol and a colour, silent to VoiceOver, in the AWS and app import steps and the plugin lists.
- Foreign key picker rows that could only be chosen with a mouse.
- No spoken sort direction on Query Plan columns.
- No columns, indexes or foreign keys listed for a MySQL server that answers `information_schema` with nothing or an error.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,15 +54,18 @@ struct AWSDiscoveryProgressStep: View {
case .pending:
Image(systemName: "circle.dotted")
.foregroundStyle(.secondary)
.accessibilityLabel(String(localized: "Not started"))
case .loading:
ProgressView()
.controlSize(.small)
case .loaded:
Image(systemName: "checkmark.circle.fill")
.foregroundStyle(.green)
.accessibilityLabel(String(localized: "Done"))
case .failed:
Image(systemName: "exclamationmark.triangle.fill")
.foregroundStyle(.orange)
.accessibilityLabel(String(localized: "Failed"))
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,14 +100,17 @@ struct ConnectionImportPreviewList: View {
Image(systemName: "checkmark.circle.fill")
.font(.callout)
.foregroundStyle(.green)
.accessibilityLabel(String(localized: "Ready"))
case .warnings:
Image(systemName: "exclamationmark.triangle.fill")
.font(.callout)
.foregroundStyle(.yellow)
.accessibilityLabel(String(localized: "Warning"))
case .unsupportedType:
Image(systemName: "exclamationmark.triangle.fill")
.font(.callout)
.foregroundStyle(.orange)
.accessibilityLabel(String(localized: "Unsupported"))
case .duplicate:
EmptyView()
}
Expand Down
2 changes: 2 additions & 0 deletions TablePro/Views/Connection/PluginRejectedBannerModifier.swift
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,11 @@ struct PluginRejectedBannerModifier: ViewModifier {
case .stagedPendingActivation:
Image(systemName: "clock.arrow.circlepath")
.foregroundStyle(.orange)
.accessibilityLabel(String(localized: "Restart to activate"))
case .completed:
Image(systemName: "checkmark.circle.fill")
.foregroundStyle(.green)
.accessibilityLabel(String(localized: "Installed"))
case .failed:
updateButton(registryPlugin: registryPlugin)
}
Expand Down
1 change: 1 addition & 0 deletions TablePro/Views/Settings/AISettingsView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ struct AISettingsView: View {
Image(systemName: "checkmark")
.font(.caption.bold())
.foregroundStyle(Color.accentColor)
.accessibilityLabel(String(localized: "Active"))
}
}
.frame(width: 14)
Expand Down
2 changes: 2 additions & 0 deletions TablePro/Views/Settings/Plugins/BrowsePluginsView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -199,10 +199,12 @@ struct BrowsePluginsView: View {
Image(systemName: "clock.arrow.circlepath")
.foregroundStyle(.orange)
.font(.caption)
.accessibilityLabel(String(localized: "Restart to activate"))
case .completed:
Image(systemName: "checkmark.circle.fill")
.foregroundStyle(.green)
.font(.caption)
.accessibilityLabel(String(localized: "Installed"))
case .failed:
Button("Retry") { retryOperation(for: plugin) }
.controlSize(.mini)
Expand Down
Loading