test(plugins): wait on the stream's producer instead of on the clock - #2977
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2972, which fixed the flake by polling. This replaces the polling with the producer saying when it is done.
holdingTheStreamKeepsItAliveasserts that a stream nobody is reading, but which is still held in scope, is not aborted: its producer runs all 20 rows. The producer paces itself at 20ms a row, so the original fixed sleep asserted the runner's load as much as the stream's behaviour, and CI saw 19 of 20. #2972 polled the counter instead, which is not a clock but is still a guess about how long to keep asking.The producer now signals once its loop ends and the test awaits that signal. An abort would leave the loop early and still signal, so the count is what decides, which is the same assertion as before.
.timeLimit(.minutes(1))is what fails a producer that never finishes, rather than the suite hanging.The suite passes three runs in a row locally.