Skip to content

test(plugins): wait on the stream's producer instead of on the clock - #2977

Merged
datlechin merged 1 commit into
mainfrom
fix/stream-test-waits-for-its-producer
Sep 18, 2026
Merged

datlechin merged 1 commit into
mainfrom
fix/stream-test-waits-for-its-producer

Conversation

@datlechin

Copy link
Copy Markdown
Member

Follow-up to #2972, which fixed the flake by polling. This replaces the polling with the producer saying when it is done.

holdingTheStreamKeepsItAlive asserts that a stream nobody is reading, but which is still held in scope, is not aborted: its producer runs all 20 rows. The producer paces itself at 20ms a row, so the original fixed sleep asserted the runner's load as much as the stream's behaviour, and CI saw 19 of 20. #2972 polled the counter instead, which is not a clock but is still a guess about how long to keep asking.

The producer now signals once its loop ends and the test awaits that signal. An abort would leave the loop early and still signal, so the count is what decides, which is the same assertion as before. .timeLimit(.minutes(1)) is what fails a producer that never finishes, rather than the suite hanging.

The suite passes three runs in a row locally.

@datlechin
datlechin merged commit e4df553 into main Sep 18, 2026
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant