fix(ios): clear leftover sample journal files before installing the sample - #2983
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2980, found while fixing the same class of bug in the Mac sample database.
Defect
SampleDatabaseInstaller.installIfNeededcopied a freshChinook.sqlitewhenever the main file was missing, but left anyChinook.sqlite-journal,-walor-shmbeside it. A reset that removed the main file and then failed on a sidecar leaves exactly that state, and SQLite replays a hot journal or WAL it finds next to a database, so the fresh copy could open with the old edits or corrupted.Fix
installIfNeededandresetshare one removal path that clears all three sidecars before copying. The tests now use their own suffix list rather than the production constant, so a missing suffix in the code fails them.Verification
iPhone 18 Pro simulator (iOS 27):
SampleDatabaseInstallerTestsandAppStateLibraryTests, 12 of 12 passed, including the new "Installing over journal files a failed reset left behind removes them first". No CHANGELOG entry: the sample database is still unreleased (#2980).