fix(ios): pre-release fixes for editing, sync, SSH keys and the connection screen - #2986
Merged
Merged
Conversation
…s unsaved changes
…he one that sees it
…sub-fields survive
…ecording its account
…d or exported secret by its kind
…path when the copy fails
…the same gate as row edits
…that holds span windows
…t only the one that sees it" This reverts commit bb966741d95d31135ffc1a58c4b80f63d28f0a33.
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pre-release fixes for the iPhone and iPad app, from the collateral review of #2980. They cover four areas: editing and sync, SSH keys, the connection screen and forms, and data safety. Each area was designed and reviewed on its own branch, then integrated here and reviewed as one diff.
Root causes and fixes
Edits, sync and local files
ConnectionFormEdits,LibraryFormEdits) and applies only that to the current record.AppState.mutateConnection,mutateGroupandmutateTagdo a read-modify-write and return aLibraryWriteOutcome. SSH tunnel and Oracle options merge field by fieldmissing,refusedandinvalidPlacementshow an alert, and amissingsave deletes the secrets it just wroteadoptAccountruns before every pull. A switch clears the token, cache, tombstones and last sync date, and keeps local edits. An install that synced before the account id was recorded starts over once. A deletion the server answers withunknownItemstops retryingSSH keys
connections.jsonSSHConfiguration.privateKeyDatawas encoded with the recordPastedSSHKeyMigrationmoves existing keys on first load without marking anything dirty, and a Keychain refusal leaves the file byte for byte unchangedConnectionManagerover an in-memoryEphemeralSecureStoreConnection screen and forms
ConfirmedWriteGateas row edits.Localization
17 strings (the save failure titles and messages, Database File Unavailable and every local file error) translated into Vietnamese, Korean, Simplified and Traditional Chinese.
localization.py --target ios verifyreports 729 of 729 in all four languages.Deliberately not fixed here
The last review round found defects in three changes that round had added. Each round kept producing new ones, so those three were cut back to main's behaviour instead of patched again:
527b059dd). It leaked a hold when a window closed with an editor open, which queued every later rebuild in every window until relaunch. It also held rebuilds for every connection, not just the edited one. The right shape is a hold keyed by connection, released on scene disconnect, and it needs its own design.Also out of scope: macOS never detects an iCloud account switch, because
checkAccountStatuswriteslastAccountIdbefore the observer compares. That needs a separate macOS change.Verification
swift test --package-path Packages/TableProCore --filter "TableProSyncTests|TableProImportTests|TableProModelsTests": all pass.public_error_text_in_log,storage_environment_*).check-ios-shared-isolation.pypasses on 21 files.Not verified: the iOS 18 to 25 layout paths (only the iOS 27 runtime is installed here), live CloudKit, a real account switch, and a device restore.