Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainhas failed Validate docs since #2988:The link is right and the checker is wrong.
docs/scripts/check-links.pyturned a heading into an anchor with[^a-z0-9]+ -> -, so it expected#pl-sql. Mintlify publishes the## PL/SQLheading asid="pl/sql"(and## SSL/TLSasssl/tls), so a#pl-sqllink would have passed CI and been broken on the live site.Changes
heading_anchorfollows the rule Mintlify publishes. I checked it against every heading on docs.tablepro.app: 1257 of 1257 ids match. A slash,&,@,_,…and curly apostrophes stay. Brackets,:,,,;,?,~and backticks are dropped. A full stop separates words the way a space does. Mintlify also curls straight quotes, and which way it curls one depends on text outside the heading, so quote characters compare as one character on both sides.#pl%2Fsqland#pl/sqlboth resolve.verify.sh docsnow runscheck-links.pytoo. It ran the other two docs checks only, which is why this passed locally and failed in CI. With the old checker put back,verify.sh docsnow reports the sameFAILCI did.verify.shgetsDEVELOPER_DIRfromxcode-select -pwhen that is a full Xcode, then falls back toXcode.app, thenXcode-beta.app. It used to tryXcode-beta.appfirst, and that app is no longer installed. The fix-issue references no longer hard-code that path. They also said TablePro targets macOS 14, butproject.ymlsetsdeploymentTargetto 13.0, so API availability advice was off by one release.No CHANGELOG entry: tooling and docs checks only.