Update blender_thumbnailer.py to read Blender 5.x files - #1481
050011-code wants to merge 3 commits into
Conversation
|
Thats on me for not remembering to fix the formating |
|
I'm sorry I was trying to make this pull request on my own fork! There are still errors as its current state was not meant to be for the original repo |
Thank you for your willingness to contribute and fix this issue. Before I start making review comments on this, I'd like to cite our
If you're not able to explain why you made specific changes in this (preferably with sources from Blender where applicable) then I'm afraid I won't review this as per our contributing policy. If you do know what you're doing with these changes and are open to me (heavily) scrutinizing the AI-assisted changes, then I'll go ahead with an in-depth review. I wouldn't pester you over exact undocumented byte ranges as long as they work, but every other change I'd want explanations for. Also, I just pulled this to actually give it a quick test, and it's not working with my Blender 5.x test file: |
|
Sorry for the conflict caused by #1483, a rebase to main should smooth that out |
|
@050011-code Any updates on this? |
|
Hey yes sorry, life has been busy so i haven't done anything on this, i should get free time this weekend to change it |
6b9e184 to
3e9296c
Compare
|
I've never done this before, do I reopen here or will that not work anymore? |
|
@050011-code Yes you should be able to reopen here, I'm not sure if you closed this yourself or if something else triggered it to close, but rebasing shouldn't trigger a PR to close |
|
I must have done something wrong, because it was automatic. |
|
Haven't fully completed the changes yet, so ignore the checks for now |
Refactor file handling to use context managers for better resource management.
|
Just to keep you up to date, we've updated the project to Python 3.14 which allows for the use of the |
|
Ok, does that mean that should be included in this pr? |
Ideally, since that would complete #1478 in time for v9.6.4, however if you want I could also pull this as-is and then add on the compressed file support myself |
|
Yeah no worries, i can add the support, it should only be a few lines. Would be by this weekend if that is ok with you? |
All good 👍 |

Summary
Updates blender_thumbnailer.py to read Blender 5.x files.
Refactor blender_thumbnailer.py to improve readability and maintainability. (Declaring this bit as AI made)
Handle file operations more safely.
Tasks Completed