Skip to content

refactor(migrations): sqlalchemy be gone - #1499

Merged
CyanVoxel merged 24 commits into
mainfrom
refactor-migrations-sqlalchemy-be-gone
Sep 15, 2026
Merged

CyanVoxel merged 24 commits into
mainfrom
refactor-migrations-sqlalchemy-be-gone

Conversation

@Computerdores

Copy link
Copy Markdown
Collaborator

Summary

Completely evict SQLAlchemy from the migrations and instead implement it in raw sqlite3.

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@Computerdores

Copy link
Copy Markdown
Collaborator Author

I have done all that I want to do in the way of refactors here at this point, so can take a look if you want @CyanVoxel.
Although I have not specifically tested the migrations beyond making sure the tests pass (no f'in clue what's happening on windows again), there should be relatively little potential for bugs in these refactors.

@Computerdores Computerdores added Type: Refactor Code that needs to be restructured or cleaned up TagStudio: Library Relating to the TagStudio library system labels Sep 3, 2026
@Computerdores Computerdores self-assigned this Sep 3, 2026
@CyanVoxel CyanVoxel moved this to 🚧 In progress in TagStudio Development Sep 3, 2026
Comment thread src/tagstudio/core/library/alchemy/migrations.py
@Computerdores

Computerdores commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator Author

note to self: fix the todo comments added here

@CyanVoxel CyanVoxel added this to the Alpha v9.6.4 milestone Sep 5, 2026
@Computerdores
Computerdores marked this pull request as ready for review September 14, 2026 11:17
@Computerdores Computerdores moved this from 🚧 In progress to 🏓 Ready for Review in TagStudio Development Sep 14, 2026
@Computerdores

Copy link
Copy Markdown
Collaborator Author

finally got the motivation to finish this.
All todos are done, should be ready for review

Comment thread src/tagstudio/core/library/alchemy/migrations.py Outdated

@CyanVoxel CyanVoxel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved when the one nit is addressed, thank you for your work on this!

@CyanVoxel CyanVoxel moved this from 🏓 Ready for Review to 🍃 Pending Merge in TagStudio Development Sep 15, 2026
@CyanVoxel CyanVoxel added Priority: High An important issue requiring attention Status: Mergeable The code is ready to be merged labels Sep 15, 2026
@Computerdores

Copy link
Copy Markdown
Collaborator Author

done

@CyanVoxel
CyanVoxel merged commit 1f1d86e into main Sep 15, 2026
12 checks passed
@github-project-automation github-project-automation Bot moved this from 🍃 Pending Merge to ✅ Done in TagStudio Development Sep 15, 2026
@CyanVoxel CyanVoxel removed the Status: Mergeable The code is ready to be merged label Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: High An important issue requiring attention TagStudio: Library Relating to the TagStudio library system Type: Refactor Code that needs to be restructured or cleaned up

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants