Fix Markdown integration gaps within bundle budgets - #17
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (37)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughChangesThe Markdown AST now supports portable inline components, configurable URL filtering, and code-fence metadata forwarding across HTML, React, and Octane renderers. Escaping, regression coverage, documentation, bundle budgets, and generated reports were updated. Portable markdown integrations
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~30 minutes Change: Feature · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The Markdown integration changes are covered across supported renderers and preserve the documented security and rendering contracts. No merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 28 functions across 15 files. (22 skipped: 22 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Changes
pre[data-meta]and highlighter options in HTML, React, and Octane.The Changeset schedules
@tanstack/markdown@0.0.15. This adds no runtime dependencies. Main renderer bundles grow 74-78 gzip bytes, about 1.1%, with exact minified, gzip, and Brotli ceilings enforced for all 22 measured entries. Standalone extensions are unchanged.Compatibility notes: metadata-bearing code fences gain an escaped
data-metaattribute, and exhaustiveInlineNodeswitches need aninlineComponentcase. Math stays outside the core. URL callback results are trusted and do not apply to raw HTML or supplied ASTs.Validation
pnpm run changeset:status: one patch release.pnpm run verify: 245 tests, typecheck, build, documentation, shipped skills, conformance, size budgets, benchmarks, and package dry-run pass.pnpm run corpus:audit:external: 10,517 Markdown files across 20 pinned repositories, no parser/determinism errors or unexplained target-profile content differences.The corpus text-extraction helper now strips markup before decoding entities, so escaped code and metadata are not mistaken for HTML. Updated reports reflect that accounting correction, not new parser regressions.
Fixes #7
Fixes #9
Fixes #11
Summary by CodeRabbit
New Features
data-metaon rendered code blocks.Bug Fixes
Documentation