test({vue,svelte}-query): add type tests for inferring the result type from a generic 'queryFn' - #11464
Merged
sukvvon merged 2 commits intoSep 10, 2026
Conversation
… from a generic 'queryFn'
…t type from a generic 'queryFn'
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe pull request adds type-level tests for generic query functions in Svelte Query and Vue Query. The tests verify inferred ChangesGeneric query inference
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This adds Vue and Svelte type coverage confirming generic query functions infer string data and nullable query errors as expected. It does not change runtime behavior or published APIs, and no merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
sukvvon
changed the title
|
View your CI Pipeline Execution ↗ for commit b0b6581
☁️ Nx Cloud last updated this comment at |
Contributor
size-limit report 📦
|
Contributor
🚀 Changeset Version Preview2 package(s) bumped directly, 23 bumped as dependents. 🟨 Minor bumps
🟩 Patch bumps
|
sukvvon
deleted the
test/vue-svelte-query-generic-queryfn-type-inference
branch
September 10, 2026 00:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
vue-queryandsvelte-querywere the only adapters without a type test covering result type inference through a genericqueryFn.react-query,preact-query,solid-query, andangular-query-experimentalall assert this in theiruseQuery/injectQuerytype tests, so this brings the two remaining adapters in line.Each new test declares a generic function whose type parameter defaults to
string, passes it as thequeryFn, and asserts that the default propagates todata:packages/vue-query/src/__tests__/useQuery.test-d.ts— newgeneric queryFndescribe, placed beforegeneric queryKey inference (#8199)so thequeryFncase precedes thequeryKeyone.packages/svelte-query/tests/createQuery/createQuery.test-d.ts— newgeneric queryFndescribe as a sibling of the existinginitialDatablock.Both assert
dataisstring | undefinedanderrorisError | null, matching the assertions the other adapters already make.Type tests only — no runtime or published code is touched.
✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.🚀 Release Impact
Summary by CodeRabbit