fix: Allow bracket characters in repo path validation - #1238
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 7add39f | Commit Preview URL Branch Preview URL |
Sep 09 2026, 11:04 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
REPO_PATH_SEGMENT_PATTERNregex insrc/utils/repo-path.tsto include[,],(, and)characters.TanStack Router uses these characters for file-based routing conventions, such as escaping literal dots (
[.]) and defining route groups ((group)). Previously, the path validation would reject legitimate example file paths containing these characters, leading to an "Error: [" issue when trying to load such examples.This change ensures that valid router-convention paths are correctly processed. It does not introduce any security vulnerabilities as existing checks for path traversal (e.g.,
..,//, leading/trailing/) remain in place.Fixes TANSTACK-COM-4ZF
This PR was automatically generated by Sentry. You can adjust this setting at any time.