Update and enhance the LPM documentation - #751
Open
ti-scaria wants to merge 2 commits into
Open
Conversation
ti-scaria
requested review from
StaticRocket,
VeeruPrudhvi,
cshilwant,
gehariprasath,
jeevantelukula,
praneethbajjuri and
uditkumarti
as code owners
July 20, 2026 13:00
github-actions
Bot
assigned
bryanbrattlof,
devarsht,
gehariprasath,
praneethbajjuri,
r-vignesh,
sskartheekadivi,
ti-scaria,
uditkumarti and
vishalmti
StaticRocket
requested changes
Jul 20, 2026
akashdeep-ti
suggested changes
Jul 21, 2026
ti-scaria
force-pushed
the
lpm_update
branch
2 times, most recently
from
July 21, 2026 09:54
a26a2b3 to
262e7a0
Compare
kwillis01
suggested changes
Jul 21, 2026
akashdeep-ti
approved these changes
Jul 23, 2026
kwillis01
approved these changes
Jul 23, 2026
StaticRocket
requested changes
Jul 23, 2026
StaticRocket
previously approved these changes
Jul 24, 2026
praneethbajjuri
approved these changes
Jul 27, 2026
praneethbajjuri
previously approved these changes
Jul 27, 2026
akashdeep-ti
suggested changes
Jul 28, 2026
| +--------------+---------------------------+----------------------------------------------+ | ||
| | Mode Value | Low Power Mode | Description | | ||
| +==============+===========================+==============================================+ | ||
| | 0 | DeepSleep | Default mode. Low latency, higher power | |
Contributor
There was a problem hiding this comment.
The description for DeepSleep is confusing, lower latency, higher power, higher to what?
We don't typically redefine these in multiple documents. TISCI is one stop document for these values. Use something like: Use the mode value as per the low power mode that is to be entered. For more detailed explanation of these modes, refer to
TISCI_MSG_LPM_SET_DEVICE_CONSTRAINT <https://software-dl.ti.com/tisci/esd/latest/2_tisci_msgs/pm/lpm.html#supported-low-power-modes>__
Contributor
Author
There was a problem hiding this comment.
Yes, will mention this as the Default mode only. The info regarding the modes are present in the LPM document itself
Reword the documentation to be generic for changing the selected low power mode in ATF. Add information about the new low power mode DSS plus Deepsleep and how it can be selected. Signed-off-by: Scaria Kochidanadu <s-kochidanadu@ti.com>
Add the documentation for using s2idle method for selecting and entering Low power modes. Enhancing the documentation by distinguishing between the power-off and suspend-to-ram LPMs available. Signed-off-by: Scaria Kochidanadu <s-kochidanadu@ti.com>
ti-scaria
dismissed stale reviews from praneethbajjuri and StaticRocket
via
July 28, 2026 07:29
dfa5945
Contributor
Author
|
Rebased |
kwillis01
approved these changes
Jul 28, 2026
madweshanshu
approved these changes
Jul 28, 2026
StaticRocket
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 1 adds the new Low power mode in the workaround page
Commit 2 is adding documentation for s2idle method and also enhacing the current LPM docs