feat[DSS7]: Document SELF_REFRESH and ALWAYS_ON_DISPLAY properties - #760
Conversation
StaticRocket
left a comment
There was a problem hiding this comment.
There's also some unnecessary use of passive voice in here
|
Don't have any comments, looks good to me. |
@StaticRocket Yeah but re-reading those sentences which vale reported, those sentences look very much understandable/readable to me and I would prefer to keep that way. But if it's a more popular opinion to always use active voice I can always modify. |
|
Technical documentation is normally declarative and uses active voice. As an example of what I mean: We are dictating the way something behaves under optimal conditions. We are not writing to a friend about something that may or may not happen due to circumstance. It makes it dry, but brief, easier to translate, and usually easier to understand. |
|
You're also bugging commit-check with that patch formatting |
Hmm, but when describing properties, passive voice is what is mostly what is preferred. See below examples from kernel docs and gstreamer docs: Kernel docs : For e.g. kernel doc uses passive voice: And here too: Gstreamer docs: force-aspect-ratio Flags : Read / Write Default value : true |
|
All of those examples could easily use active voice to convey the same thing in fewer words:
Peak video bitrate in bits per second. Must be larger or equal to the average video bitrate. When using a constant bitrate this value does nothing.
The Coded Picture Buffer size in kilobytes. This can be a limitation of frame skip. That sentence is a little weird as written though. Think you may have left some part of it off. The way it was written is a little vague. Any project is free to do what it wants, I'm just trying to enforce standard practices here. |
ff79076 to
e4bdbff
Compare
Alright, thanks for sharing, Updated the PR as suggested. |
Yes, fixed that too. |
7875332 to
ec12f01
Compare
StaticRocket
left a comment
There was a problem hiding this comment.
Slight rephrasing suggested. Also, apparently I didn't notice the previous userspace usage. Trying to standardize on either the traditional user space or kernel user-space notation.
akashdeep-ti
left a comment
There was a problem hiding this comment.
Just one minor comment (ignore if it is not valid). Otherwise, LGTM
I would suggest that be a global change that could be a separate PR in itself across all linux docs: grep -inlr userspace source/linux |
Add the SELF_REFRESH (plane) and ALWAYS_ON_DISPLAY (crtc) DRM properties to the tidss properties table, along with usage sections describing their behaviour and modetest examples, following the format used for the other documented properties. Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
Add the SELF_REFRESH (plane) and ALWAYS_ON_DISPLAY (crtc) DRM properties to the tidss properties table, along with usage sections describing their behaviour and modetest examples, following the format used for the other documented properties.