Removed REMOVE_LIBS_FOR_LEC workaround - #4469
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the REMOVE_LIBS_FOR_LEC configuration variable and its references across documentation, variable definitions, and several design configuration files (bp_dual, bp_quad, bp_single, and coyote). The review feedback suggests adding a trailing newline to the modified config.mk files, as removing the configuration blocks left them without one, which can cause compatibility issues with text-processing tools.
I am having trouble creating individual review comments. Click here to see my feedback.
flow/designs/gf12/bp_dual/config.mk (71-78)
While removing this block is correct, it appears to leave the file without a trailing newline. It's a good practice to end text files with a newline character for better compatibility with various tools (e.g., POSIX-based tools like cat, wc). Please add a trailing newline to the file.
flow/designs/gf12/bp_quad/config.mk (73-80)
Similar to the other config files in this PR, removing this block seems to leave the file without a trailing newline. For consistency and to ensure compatibility with standard text-processing tools, please add a trailing newline.
flow/designs/gf12/bp_single/config.mk (75-82)
After removing this block, the file will be missing a trailing newline. Please add one to adhere to common file formatting conventions and prevent potential issues with shell scripts or other tools that process this file.
flow/designs/gf12/coyote/config.mk (42-52)
This change removes the trailing newline from the file. It's a best practice to ensure all text files end with a newline. Could you please add it back?
added trailing newline Signed-off-by: Jeff Ng <jeffng@precisioninno.com>
|
added trailing newlines |
286e559 to
a70d6a9
Compare
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Advisory — results are log-only and do not affect build status. The authoritative QoR gate remains the local rules-file check. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.
|
3 participants
With the kepler-formal Liberty fixes, the REMOVE_LIBS_FOR_LEC override is no longer needed. Removed from gf12 configs.