update metrics for GPL min congestion - #4491
Merged
vvbandeira merged 10 commits intoSep 1, 2026
Merged
Conversation
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
…gestion-inflation
…gestion-inflation
…gestion-inflation
## make update_ok for chameleon (sky130hd)... designs/sky130hd/chameleon/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | cts__timing__setup__ws | -3.21 | -2.96 | Tighten | | cts__timing__setup__tns | -134.0 | -172.0 | Failing | | globalroute__antenna_diodes_count | 138 | 181 | Failing | | globalroute__timing__setup__ws | -2.96 | -2.82 | Tighten | | globalroute__timing__setup__tns | -92.5 | -151.0 | Failing | | detailedroute__antenna__violating__nets | 0 | 1 | Failing | | detailedroute__antenna_diodes_count | 119 | 162 | Failing | | finish__timing__setup__ws | -2.52 | -2.41 | Tighten | | finish__timing__setup__tns | -85.6 | -146.0 | Failing | ## make update_ok for microwatt (sky130hd)... designs/sky130hd/microwatt/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | cts__timing__setup__ws | -2.1 | -2.08 | Tighten | | cts__timing__setup__tns | -243.0 | -226.0 | Tighten | | globalroute__antenna_diodes_count | 3431 | 3061 | Tighten | | globalroute__timing__setup__ws | -2.21 | -2.03 | Tighten | | globalroute__timing__setup__tns | -262.0 | -208.0 | Tighten | | detailedroute__antenna__violating__nets | 69 | 120 | Failing | | detailedroute__antenna_diodes_count | 1425 | 1552 | Failing | | finish__timing__setup__ws | -2.11 | -1.91 | Tighten | | finish__timing__setup__tns | -203.0 | -171.0 | Tighten | ## make update_ok for jpeg (sky130hs)... designs/sky130hs/jpeg/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | globalroute__antenna_diodes_count | 100 | 111 | Failing | | globalroute__timing__setup__tns | -3.0 | -1.52 | Tighten | ## make update_ok for swerv_wrapper (nangate45)... designs/nangate45/swerv_wrapper/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | cts__timing__setup__tns | -463.0 | -467.0 | Failing | | globalroute__timing__setup__tns | -504.0 | -545.0 | Failing | | finish__timing__setup__tns | -442.0 | -515.0 | Failing | ## make update_ok for ibex (nangate45)... designs/nangate45/ibex/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | globalroute__timing__setup__ws | -0.111 | -0.11 | Tighten | | globalroute__timing__setup__tns | -0.441 | -0.44 | Tighten | | finish__timing__setup__tns | -1.08 | -1.81 | Failing | Large percentage changes in failing metrics (>50%): - microwatt (sky130hd) detailedroute__antenna__violating__nets 73.91% (69 → 120) - chameleon (sky130hd) finish__timing__setup__tns 70.56% (-85.6 → -146.0) - ibex (nangate45) finish__timing__setup__tns 67.59% (-1.08 → -1.81) - chameleon (sky130hd) globalroute__timing__setup__tns 63.24% (-92.5 → -151.0) Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the OpenROAD submodule to a newer commit and adjusts various timing, antenna diode, and violating net thresholds in the rules-base.json files across multiple designs (ibex, swerv_wrapper, chameleon, microwatt, and jpeg). The feedback recommends adding a trailing newline to the rules-base.json file for the swerv_wrapper design to follow standard formatting practices and prevent future diff noise.
| "compare": "<=" | ||
| } | ||
| } | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
The file is missing a newline character at the end. Adding a trailing newline is a standard practice that prevents future diff noise and ensures compatibility with POSIX utilities.
Suggested change
| } | |
| } | |
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Advisory — results are log-only and do not affect build status. The authoritative QoR gate remains the local rules-file check. Commit 63 design(s) checked — 11 with regression(s), 2 without a comparable baseline.
❌ asap7/mock-alu base — 1 failing metric(s)
❌ nangate45/ibex base — 1 failing metric(s)
❌ nangate45/mempool_group base — 3 failing metric(s)
❌ nangate45/swerv_wrapper base — 3 failing metric(s)
❌ sky130hd/chameleon base — 6 failing metric(s)
❌ sky130hd/jpeg base — 2 failing metric(s)
❌ sky130hd/microwatt base — 2 failing metric(s)
❌ sky130hd/riscv32i base — 2 failing metric(s)
❌ sky130hs/ibex base — 3 failing metric(s)
❌ sky130hs/jpeg base — 1 failing metric(s)
❌ sky130hs/riscv32i base — 3 failing metric(s)
|
…gestion-inflation
Contributor
Author
|
@eder-matheus I believe this is good to merge, we only have a single failing design in a private PDK. |
Contributor
Author
|
I don't understand why we have a conflict with OR submodule here, I have never seen that. |
eder-matheus
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update metrics for OR PR: The-OpenROAD-Project/OpenROAD#10977
make update_ok for chameleon (sky130hd)...
designs/sky130hd/chameleon/rules-base.json updates:
make update_ok for microwatt (sky130hd)...
designs/sky130hd/microwatt/rules-base.json updates:
make update_ok for jpeg (sky130hs)...
designs/sky130hs/jpeg/rules-base.json updates:
make update_ok for swerv_wrapper (nangate45)...
designs/nangate45/swerv_wrapper/rules-base.json updates:
make update_ok for ibex (nangate45)...
designs/nangate45/ibex/rules-base.json updates:
Large percentage changes in failing metrics (>50%):