rsz: Preserve dont-touch on hierarchical nets - #11207
Open
jhkim-pii wants to merge 1 commit into
Open
Conversation
Resolve hierarchical STA nets to their corresponding flat dbNet before reading or updating the dont-touch flag. This avoids treating a dbModNet as a dbNet and corrupting the hierarchical net name in release builds. Report an error for unresolvable nets and add a regression covering name preservation, flat-net protection, and hierarchical reads. Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates Resizer::setDontTouch and Resizer::dontTouch to retrieve flat nets using findFlatDbNet instead of staToDb, and adds a unit test to verify hierarchical net protection. However, a critical issue was identified in Resizer::setDontTouch where a null pointer dereference will occur if db_net is null, as the code logs an error but does not return before calling setDoNotTouch.
Contributor
Author
|
@codex review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve hierarchical
set_dont_touchnets to their corresponding flat dbNet.Fixes #11180