Skip to content

dbSta: conditionally enable OpenSTA analysis_corner support - #11261

Open
dsengupta0628 wants to merge 3 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:support_analysis_corner
Open

dbSta: conditionally enable OpenSTA analysis_corner support#11261
dsengupta0628 wants to merge 3 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:support_analysis_corner

Conversation

@dsengupta0628

Copy link
Copy Markdown
Contributor

Summary

The OpenROAD fork of OpenSTA adds an analysis_corner feature (per-corner SDC, liberty/spef bundles); stock parallaxsw OpenSTA does not have it. This change exposes the feature in the openroad binary without breaking builds against stock OpenSTA:

  • dbSta.i: includes search/AnalysisCorner.i behind an STA_HAS_ANALYSIS_CORNER guard.
  • CMake: probes for the file in the OpenSTA submodule; when present, sets the guard and embeds tcl/AnalysisCorner.tcl. With stock OpenSTA the probe fails and the build is unchanged.
  • Bazel: sets the guard via swig_options (the pinned submodule is the fork; remove the define if swapping in stock OpenSTA — Bazel cannot probe file existence).

With the fork submodule, corner commands work in openroad; with stock OpenSTA, openroad builds and behaves exactly as today. The fork's Tcl also degrades gracefully in any binary lacking the swig module (guards pass through), so a mismatched combination fails soft rather than breaking SDC commands.

Type of Change

  • New feature

Impact

Allows using new commands in The-OpenROAD-Project/OpenSTA#394

Verification

  • I have verified that the local build succeeds (./etc/Build.sh).
  • I have run the relevant tests and they pass.
  • My code follows the repository's formatting guidelines.
  • I have included tests to prevent regressions.
  • I have signed my commits (DCO).

…s compilation with parallaxsw/opensta

Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
@dsengupta0628 dsengupta0628 self-assigned this Aug 28, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the src/sta submodule and introduces conditional support for AnalysisCorner in dbSta. It adds build configuration checks in CMakeLists.txt and BUILD to define STA_HAS_ANALYSIS_CORNER and include AnalysisCorner.i and AnalysisCorner.tcl only when they are available in the OpenSTA submodule, ensuring compatibility with stock OpenSTA. I have no feedback to provide.

@dsengupta0628
dsengupta0628 marked this pull request as ready for review August 28, 2026 19:51
@dsengupta0628
dsengupta0628 requested review from a team as code owners August 28, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants