dbSta: conditionally enable OpenSTA analysis_corner support - #11261
Open
dsengupta0628 wants to merge 3 commits into
Open
dbSta: conditionally enable OpenSTA analysis_corner support#11261dsengupta0628 wants to merge 3 commits into
dsengupta0628 wants to merge 3 commits into
Conversation
…s compilation with parallaxsw/opensta Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the src/sta submodule and introduces conditional support for AnalysisCorner in dbSta. It adds build configuration checks in CMakeLists.txt and BUILD to define STA_HAS_ANALYSIS_CORNER and include AnalysisCorner.i and AnalysisCorner.tcl only when they are available in the OpenSTA submodule, ensuring compatibility with stock OpenSTA. I have no feedback to provide.
jhkim-pii
approved these changes
Aug 29, 2026
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The OpenROAD fork of OpenSTA adds an analysis_corner feature (per-corner SDC, liberty/spef bundles); stock parallaxsw OpenSTA does not have it. This change exposes the feature in the openroad binary without breaking builds against stock OpenSTA:
With the fork submodule, corner commands work in openroad; with stock OpenSTA, openroad builds and behaves exactly as today. The fork's Tcl also degrades gracefully in any binary lacking the swig module (guards pass through), so a mismatched combination fails soft rather than breaking SDC commands.
Type of Change
Impact
Allows using new commands in The-OpenROAD-Project/OpenSTA#394
Verification
./etc/Build.sh).