Skip to content

odb: ignore duplicated macros - #11270

Open
gadfort wants to merge 2 commits into
The-OpenROAD-Project:masterfrom
gadfort:odb-dup-macro
Open

odb: ignore duplicated macros#11270
gadfort wants to merge 2 commits into
The-OpenROAD-Project:masterfrom
gadfort:odb-dup-macro

Conversation

@gadfort

@gadfort gadfort commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Summary

I was debugging something and noticed that if macros are read twice they merge. In other places we simply ignore duplicates, this add a warning and ensures we ignore the second read of the file.

Type of Change

  • Bug fix

Impact

N/A

Verification

  • I have verified that the local build succeeds (./etc/Build.sh).
  • I have run the relevant tests and they pass.
  • My code follows the repository's formatting guidelines.
  • I have included tests to prevent regressions.
  • I have signed my commits (DCO).

Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
@gadfort
gadfort requested review from a team as code owners August 30, 2026 22:05

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a check in lefinReader::macroBegin to ignore duplicate MACRO definitions when the master is already frozen, logging a warning instead of merging or overwriting. It also adds a dedicated test case and updates several existing test expectations to account for the new warning and the reduced library cell counts. There are no review comments, so no feedback is provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant