odb: ignore duplicated macros - #11270
Open
gadfort wants to merge 2 commits into
Open
Conversation
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a check in lefinReader::macroBegin to ignore duplicate MACRO definitions when the master is already frozen, logging a warning instead of merging or overwriting. It also adds a dedicated test case and updates several existing test expectations to account for the new warning and the reduced library cell counts. There are no review comments, so no feedback is provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I was debugging something and noticed that if macros are read twice they merge. In other places we simply ignore duplicates, this add a warning and ensures we ignore the second read of the file.
Type of Change
Impact
N/A
Verification
./etc/Build.sh).